Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rTorrent: improve session saving support #5727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spk/rutorrent/src/rtorrent.rc
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ dht.mode.set = auto
dht.port.set = 6881
protocol.pex.set= yes
port_range = 6881-6999
schedule2 = session_save, 1200, 3600, ((session.save))
method.set_key = event.download.inserted, 2_save_session, ((d.save_full_session))
Comment on lines +16 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question: this will only be applied on new installation and won't be applied on upgrade. Is this something we want or would we want to try to amend existing installation's configurations on upgrade ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, session saving could present challenges for NAS environments. It highly possible to consume more resources writing session files with torrent information to disk than actually seeding torrents. RAID 5 in particular is very suspectable to this issue.

This and the potential to lose torrents is why I would recommend amending existing installs.