-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sabnzbd update to version 3.61 #5410
Conversation
Nice! |
|
||
LDADD = -lstdc++ | ||
-AM_CXXFLAGS = -Wall -std=c++11 $(OPENMP_CXXFLAGS) | ||
+AM_CXXFLAGS = -Wall -std=c++0x $(OPENMP_CXXFLAGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.11 requires C++17, so for a moment I thought this would exclude the 88f6281 arch when Python 3.11 is released.
But seems it should still work, if the right flags are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++17 requirement will drop all DSM <7 builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, meant C++11!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even c++11
will require dropping gcc<4.9
.
BTW @Safihre I'm pushing this PR as I noticed a bug in service-setup.sh
where the incomplete
, complete
and watch
directories under downloads
are not group write permitted which impacts other packages. I've come-up with a method to alleviate that even on DSM7 such as https://github.com/SynoCommunity/spksrc/pull/5398/files#diff-0be67c7c2427a76d082fddbe7509dbf6111868c62f50d755bb1318131fa7dc1a
Therefore I took the opportunity to create an updated package so any new install do not block other packages.
But other than that this package served me as a perfect example to nail down deluge
hopefully once and for all :)
@Safihre would you have spare cycles to give this one a shot to confirm all is looking good? |
Tested and it works, only tested DSM 7. |
Thnx, much appreciated! |
Description
This is a follow-up to #5398 which includes changes to the
service-setup.sh
script. This update will ensure that the permission adjustments are being propagated to next package release.Fixes n/a
Checklist
all-supported
completed successfullyType of change