-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setuptools and use get-pip
correctly to fix Cryptography build
#5316
Conversation
@Safihre now I get it, great catch! I recall seing messages that it was replacing a version with another on the subsequent install of wheel and setuptools and that explains it now. Good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've restarted the github-action checks to confirm all is good but at first glance this LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! However, I would like the builds for python to succeed.
I saw 😢 , making changes in a separate branch to fix. Will push when fixed :) |
@hgy59 @publicarray @th0ma7 I fixed |
I double checked and indeed it doesn't looked used anymore. So no objection at all besides updating python310 status page #5043 |
Build succeeded: |
- update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13 - remove static libpython (3.10 has configure arg, 3.8 needs manual removal) - pip: install specific version of pip with get-pip.py (revert change by SynoCommunity#5316) - pip: avoid unintended update of pip with --disable-pip-version-check
Additional parameters to pip-get.py are documented https://github.com/pypa/get-pip
|
Hmm, strange that I saw in the logs that it wasn't installing the version we specify. I must have misunderstood the logging. |
AFAICR there was "pip = 20.0.4" (single eq) once in your PR... |
- update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13 - remove static libpython (3.10 has configure arg, 3.8 needs manual removal) - pip: install specific version of pip with get-pip.py (revert change by SynoCommunity#5316) - pip: avoid unintended update of pip with --disable-pip-version-check
* Update Python 3.8 and 3.10 - update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13 - remove static libpython (3.10 has configure arg, 3.8 needs manual removal) - pip: install specific version of pip with get-pip.py (revert change by #5316) - pip: avoid unintended update of pip with --disable-pip-version-check * vim: use Python 3.10 for python support * ffsync does not build anymore - requirements file handling to create wheels has changed - might never be working, as still python 2 - future update is redesigned using rust * fix (optimized) build for DSM 5.2 and 88f6281 (ARMv5)
As discussed in #5307 and #4153.
Turns out we need to update
setuptools
.I also found that our usage of
get-pip.py
was wrong: it can't be used to specify the pip version, it always installs whatever they have update the script to.But by skipping
setuptools
andwheel
inget-pip.py
, we can make sure we fix those versions at least.Successful build of SABnzbd (setup and runs):
https://github.com/Safihre/spksrc/actions/runs/2514098758