Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subversion: initial package #5296

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented May 31, 2022

Description

Synology does not support subversion on DSM 7, so there are some requests for an svn package.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • New Package
  • This change requires a documentation update (e.g. Wiki)

@cpm1
Copy link

cpm1 commented Jun 19, 2023

Hey! Any progress on this? I'm waiting for it to finally be able to update my DSM :D

@hgy59
Copy link
Contributor Author

hgy59 commented Oct 6, 2023

This PR depends on #5649.

And I will add a dedicated web ui package (probably usvn)

@matt-hall-zory
Copy link

Any progress? I can see the PR you were depending on has been merged.

hgy59 added 5 commits December 5, 2023 18:03
- update cross/apr to v1.7.2
- update cross/apr-util to v1.6.3
- configure subversion to use serf
- use alternate port 3691 to avoid conflicts with SVN package from Synology
- use service-variables file to configure shared folder at installation time
- add wizard to define shared folder for repositories
hgy59 added 3 commits December 5, 2023 23:15
- update serf for openssl3 compatibility
- update cyrus-sasl and depend on openssl3
@hgy59
Copy link
Contributor Author

hgy59 commented Dec 5, 2023

Any progress? I can see the PR you were depending on has been merged.

I did some updates now, but see and issue on aarch64

svnadmin: E200029: Couldn't perform atomic initialization
svnadmin: E070023: Can't create fsync thread pool in FSX: This function has not been implemented on this platform

I have to validate other archs...

@matt-hall-zory If you don't mind, you could manually install the package built by github build action.

@hgy59
Copy link
Contributor Author

hgy59 commented Dec 5, 2023

Still no web ui added to the package
candidates are websvn and usvn
When possible, dedicated packages for those might be better.

- update mutt and depend on openssl3
@cpm1
Copy link

cpm1 commented Nov 24, 2024

Almost one more year later without SVN on Diskstation :(

Can we please get this much needWanted package going? IMHO there is no need for a Web UI integrated in this package. I'd actually prefer dedicated server and web ui packages as they would be easier to maintain individually.

Pretty please? :)

@hgy59
Copy link
Contributor Author

hgy59 commented Nov 24, 2024

@cpm1 you are lucky, just started yesterday to move the unintended changes on mutt to a dedicated PR #6328.

and yes, subversion package is long overdue...

@hgy59
Copy link
Contributor Author

hgy59 commented Nov 24, 2024

@cpm1 do you have some time to test the package created by the github build action?

just navigate to the build action and under artifacts download the zip archive for your model (arch).
then extract the spk file from the zip archive and manually install it in dsm package center.

EDIT:
please regard that the svn server port of this package is 3691. This is to avoid conflicts with default port 3690 (synology svn package on DSM 6).

- use archive url for download (remains valid after upstream updates)
@cpm1
Copy link

cpm1 commented Nov 25, 2024

@hgy59 Great! I'll install it, give it a spin and report back in one or two days.

Edit: sorry, I'm too dumb. All I can find as artifacts are zip files with the content of the spk's, but no ready to install spk. Where did I turn the wrong way?

@mreid-tt
Copy link
Contributor

Edit: sorry, I'm too dumb. All I can find as artifacts are zip files with the content of the spk's, but no ready to install spk. Where did I turn the wrong way?

If you expand the zip file and don't get an SPK it's because your decompression software is also decompressing the SPK file. You can check your settings or use another decompression software that won't try to also decompress the SPK file.

@cpm1
Copy link

cpm1 commented Nov 27, 2024

If you expand the zip file and don't get an SPK it's because your decompression software is also decompressing the SPK file.

Oops! Of course, you are right as am I with being dumb xD Extracted properly now, installed and first simple tests were successfull. Thank you very much!

Just the custom port is a bit irritating. It really should stay the default port at least on DSM7+. Or even better, allow the port to be specified at install time and/or changed via settings later.

@mreid-tt
Copy link
Contributor

Just the custom port is a bit irritating. It really should stay the default port at least on DSM7+. Or even better, allow the port to be specified at install time and/or changed via settings later.

Synology packages typically do not support dynamic port allocation, as the port needs to be explicitly defined during the build process:

SERVICE_PORT = 3691

For Subversion, we could use the default port (3690). If the port is already in use on DSM, the system will detect the conflict and block the installation. To address this, we could adopt an approach where DSM 6 uses a custom port while DSM 7 retains the default port, reducing the likelihood of conflicts.

@hgy59, what are your thoughts on sticking with the default port? Since SVN is a third-party package, using the same port would align with our approach for Jellyfin, which shares a port with the third-party app Emby. Alternatively, we could implement a version-dependent port allocation, similar to the strategy used for MariaDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package PR/WIP for a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants