Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffmpeg zvbi addition #4864

Merged
merged 9 commits into from
Sep 20, 2021
Merged

Ffmpeg zvbi addition #4864

merged 9 commits into from
Sep 20, 2021

Conversation

arnebjarne
Copy link
Contributor

Motivation: Explain here what the reason for the pull request is.
Linked issues: Optionally, add links to existing issues or other PR's

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx for your contribution, this is greatly appreciated. Overall proposed changes looks good. I see a lot of patches added and some of them do not seems to be a fit for the environment, please adjust as needed based on review. Also all these patches will add to maintenance burden on new software releases but is probably manageable.

cross/zvbi/PLIST Outdated Show resolved Hide resolved
spk/ffmpeg/Makefile Outdated Show resolved Hide resolved
cross/zvbi/patches/06_sizeof-FTBFS.patch Outdated Show resolved Hide resolved
cross/zvbi/patches/09_fix-FTBFS-GCC6.patch Show resolved Hide resolved
cross/ffmpeg/Makefile Show resolved Hide resolved
@th0ma7
Copy link
Contributor

th0ma7 commented Sep 16, 2021

I notice that failures seems to be due to connection time out and not actual build failures.

Also note that in order to release a new ffmpeg I normally do a full round of updates as I also have to tie-in other dependencies (tvheadend, chromaprint and comskip). Before releasing a new package I have an issue to fix with tvheadend first so this may take a few cycles to get published (which does mean you can't build yourself an updated version).

@th0ma7 th0ma7 linked an issue Sep 16, 2021 that may be closed by this pull request
Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing PLIST and moving patch under arm looks like all remaining to do.

cross/zvbi/PLIST Outdated Show resolved Hide resolved
@arnebjarne arnebjarne requested a review from th0ma7 September 19, 2021 19:17
Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job.

@th0ma7 th0ma7 merged commit 3fbf0c9 into SynoCommunity:master Sep 20, 2021
@th0ma7
Copy link
Contributor

th0ma7 commented Sep 20, 2021

I'll look into publishing the update within the next few days when I have more cycles.

@arnebjarne arnebjarne deleted the ffmpeg-zvbi branch September 20, 2021 20:11
@th0ma7 th0ma7 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFMPEG package not built with libzvbi option
2 participants