-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ffmpeg zvbi addition #4864
Ffmpeg zvbi addition #4864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnx for your contribution, this is greatly appreciated. Overall proposed changes looks good. I see a lot of patches added and some of them do not seems to be a fit for the environment, please adjust as needed based on review. Also all these patches will add to maintenance burden on new software releases but is probably manageable.
cross/ffmpeg/patches/034-avcodec-arm-sbcenc-avoid-callee-preserved-vfp-regist.patch
Outdated
Show resolved
Hide resolved
I notice that failures seems to be due to connection time out and not actual build failures. Also note that in order to release a new ffmpeg I normally do a full round of updates as I also have to tie-in other dependencies (tvheadend, chromaprint and comskip). Before releasing a new package I have an issue to fix with tvheadend first so this may take a few cycles to get published (which does mean you can't build yourself an updated version). |
Had forgotten to update the package version & comment out on changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing PLIST
and moving patch under arm
looks like all remaining to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good job.
I'll look into publishing the update within the next few days when I have more cycles. |
Motivation: Explain here what the reason for the pull request is.
Linked issues: Optionally, add links to existing issues or other PR's
Checklist
all-supported
completed successfully