Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lldpd spk package #4554

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add lldpd spk package #4554

wants to merge 4 commits into from

Conversation

ixs
Copy link
Contributor

@ixs ixs commented Apr 14, 2021

Add a lldpd package that runs the lldp daemon from http://lldpd.github.io allowing the synology device to be discovered on the network.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@hgy59 hgy59 added the new-package PR/WIP for a new package label Apr 7, 2023
- update lldpd to v1.0.18
- remove obsolete privilege and PLIST file
- enable all built in protocols
- build binaries into bin folder (instead of sbin)
- use quadratic shape for logo
- use group synocommunity (for DSM 7 compatibility)
- user SERVICE_USER = auto (other values are not supported)
@hgy59
Copy link
Contributor

hgy59 commented Nov 25, 2024

@ixs are you still using lldpd for Synology?

I applied an update and some adjustments.
For DSM < 7 it works out of the box.

For DSM 7 it needs manual adjustment of the previlege file to allow the package execution as root. (will add a related wizard page with instructions for DSM 7 later).

@ixs
Copy link
Contributor Author

ixs commented Nov 25, 2024

@hgy59 I have been using it with < 7 but when after the upgrade, I stumbled over the problem you described and did not get around to fixing things yet.
Your change otherwise looks pretty good.

What is needed for the privilege file?

Is - libcap: Arch 88f6281 is not a supported architecture a known problem?

@hgy59
Copy link
Contributor

hgy59 commented Nov 25, 2024

What is needed for the privilege file?

After installation (and after repair or upgrade) the privilege file must be modified to replace the user definition "package" by "root".

To do so call sudo sed -i 's/package/root/g' /var/packages/lldpd/conf/privilege and finally start the package with sudo synopkg start lldpd.

But this needs further validation. For lldpd to work under DSM 7, I manually started the daemon once like this:
/var/packages/lldpd/target/bin/lldpd -d
Then (when no error was logged) terminated with Ctl+C and started with synopkg.

So there are some pending tasks:

  • add wizard page for DSM 7 with instructions to run the package as root
  • evaluate whether the initial manual start is required or how it can be fixed otherwise
  • didn't find a solution to get logs from lldpd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package PR/WIP for a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants