-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db creation to demoservice #4497
base: master
Are you sure you want to change the base?
Conversation
@hgy59 Would it be possible to also produce a database dump from a wizard checkbox before deletion? probably requesting for a dump destination folder, using an obvious file name like "mysql_schema_timestamp.dump.gz" for instance. |
As I am currently working on ffsync this would be a logical extension. |
For DSM7 if you need testers let me know. |
Hm so we have to create different json for DSM6 or DSM7... You might like this bit, for removing the db only when the user wants to: spksrc/spk/wallabag/src/installer.sh Lines 66 to 75 in eea7230
|
The current code has already implemented this behaviour, but does not need any code like you propose. The variables are already in the uninstall-wizard. And AFAICS this is compatible with DSM 7. |
Thanks @hgy59. From memory it did not work correctly on DSM7 (hence my workaround) but maybe it will be fixed before DSM7 is released. Woud be possable to have an example that works on both DSM6 and DSM7? Otherwise good job. |
The additional changes can be added in a follow-up PR |
- add demo of creating an mysql db with resource definition - add uninstall wizard to optionally drop the database and/or the db user
329b81b
to
8f39109
Compare
- use resource worker to create shared folder - adjust wizards for shared folder creation - create readme.html that can be opened in the browser - create dummy file as for DSM7 we cannot create packages without content (since SynoCommunity#5163: Fully use DSM7 var directory)
Motivation: Demonstrate the creation of MySQL Database with resource configuration.
Linked issues:
Checklist
all-supported
completed successfullyRemarks