native/go: Fix build issue when first invoke through cross-build #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hgy59
reviewed
Jan 12, 2021
|
@hgy59 and @ymartin59 do you think this one is good for a merge? I believe so but rather have a second opinion first. |
ymartin59
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
native/gofails to build when first invoked from a cross-build (e.g. non-x86_64). Forcing the build environment for amd64 along with setting the defaultgccandg++to use the docker built-in compiler solves this.Linked issues: #4292
Checklist
all-supportedcompleted successfully