Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rar2fs #3990

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added rar2fs #3990

wants to merge 9 commits into from

Conversation

rohtang
Copy link

@rohtang rohtang commented May 15, 2020

Motivation: Added support for rar2fs
Linked issues: N/A

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rohtang Thanks for your contribution.
It does not sound relevant to publish a package for such a small single tool.
I propose to include it in existing spk/synocli-file and move current spk/rarfs as diyspk/rarfs
There is also no need for dsm-control.sh and installer.sh in "rarfs" package thanks to recently added SPK_COMMANDS and SPK_LINKS variables.

@rohtang
Copy link
Author

rohtang commented May 16, 2020

Hi @ymartin59 ,

Thanks for your feedback. I was unaware of spk/synocli-file, but that seems like a reasonable location to me!

I've made the requested changes in my latest commit.

cross/rar2fs/Makefile Outdated Show resolved Hide resolved
spk/synocli-file/Makefile Outdated Show resolved Hide resolved
@rohtang rohtang requested a review from ymartin59 May 28, 2020 13:32
PRE_CONFIGURE_TARGET = fulfill_rar2fs_prerequisite
PRE_COMPILE_TARGET = build_unrar_static
HOMEPAGE = https://github.com/hasse69/rar2fs
COMMENT = sshfs is a network filesystem client to connect to SSH servers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commend references sshfs. This should be updated to reflect rarfs.

@hgy59 hgy59 added new-package PR/WIP for a new package new-cli-tool new tool for a syncli-package and removed new-package PR/WIP for a new package labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-cli-tool new tool for a syncli-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants