-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rar2fs #3990
base: master
Are you sure you want to change the base?
Added rar2fs #3990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rohtang Thanks for your contribution.
It does not sound relevant to publish a package for such a small single tool.
I propose to include it in existing spk/synocli-file and move current spk/rarfs as diyspk/rarfs
There is also no need for dsm-control.sh and installer.sh in "rarfs" package thanks to recently added SPK_COMMANDS
and SPK_LINKS
variables.
Hi @ymartin59 , Thanks for your feedback. I was unaware of spk/synocli-file, but that seems like a reasonable location to me! I've made the requested changes in my latest commit. |
PRE_CONFIGURE_TARGET = fulfill_rar2fs_prerequisite | ||
PRE_COMPILE_TARGET = build_unrar_static | ||
HOMEPAGE = https://github.com/hasse69/rar2fs | ||
COMMENT = sshfs is a network filesystem client to connect to SSH servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commend references sshfs. This should be updated to reflect rarfs.
Motivation: Added support for rar2fs
Linked issues: N/A
Checklist
all-supported
completed successfully