Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imapfilter: initial package for imapfilter v2.6.16 #3836

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

VanStratum
Copy link

@VanStratum VanStratum commented Dec 28, 2019

Motivation: Initial package for imapfilter. Imapfilter allows to apply complex mail filtering rules over IMAP using lua as a scripting language.
Linked issues:

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully
    The package works properly, but for some reasons unknown to me, the executable files are not linked properly to /usr/local.

Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great job done.
Proposed some small changes.

Since imapfilter is a CLI tool for advanced users I propose to add it to synocli-net.
And when adding to synocli-net, move the spk/imapfilter to diyspk/imapfilter.

There is no automatic link creation for the executables to /usr/local/bin. You have to provide a service-setup script for this.

cross/imapfilter/Makefile Show resolved Hide resolved
spk/imapfilter/Makefile Outdated Show resolved Hide resolved
cross/imapfilter/Makefile Outdated Show resolved Hide resolved
spk/imapfilter/Makefile Outdated Show resolved Hide resolved
VanStratum added a commit to VanStratum/spksrc that referenced this pull request Jan 3, 2020
Add service-setup script.
Change name of downloaded tgz.
Fix dependencies of the spk.
Add rule to compile on ppc platforms.
Remove beta status.
Move to diyspk.
@VanStratum
Copy link
Author

VanStratum commented Jan 3, 2020

Thank you for the feedback.
I added the requested changes, but before adding the package to synocli-net, I would like to
know how I should increment the the version number and the revision, and how the changelog
should be written, because the history of it doesn't seems consistent.

@VanStratum
Copy link
Author

If I understand correctly the way the changelog and the revision number works,
the revision number should be 5 and the changelog

CHANGELOG = "5. Add imapfilter
4. Add rsync
3. Build sshfs 2.10 with fuse updated to v2.9.9
2. Add fritzctl
1. First package release"

Should I commit this changelog and "correct" the revision number, or am I misunderstanding something?

Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hgy59 In case we get Meson to cross-compile for fuse in synocli-net

diyspk/imapfilter/Makefile Outdated Show resolved Hide resolved
diyspk/imapfilter/src/service-setup.sh Outdated Show resolved Hide resolved
@VanStratum
Copy link
Author

VanStratum commented May 9, 2020 via email

hgy59 pushed a commit to VanStratum/spksrc that referenced this pull request Dec 30, 2020
Add service-setup script.
Change name of downloaded tgz.
Fix dependencies of the spk.
Add rule to compile on ppc platforms.
Remove beta status.
Move to diyspk.
@hgy59
Copy link
Contributor

hgy59 commented Dec 31, 2020

@th0ma7 the meson build (#4307) does not work in the spksrc build environment.
It tries to run cross-compiled sanitycheckc.exe:

meson.build:1:0: ERROR: Could not invoke sanity test executable: [Errno 8] Exec format error: '/spksrc/spk/synocli-file/work-armv7-6.1/glib-2.62.6/builddir/meson-private/sanitycheckc.exe'.

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 31, 2020

@th0ma7 the meson build (#4307) does not work in the spksrc build environment.
It tries to run cross-compiled sanitycheckc.exe:

meson.build:1:0: ERROR: Could not invoke sanity test executable: [Errno 8] Exec format error: '/spksrc/spk/synocli-file/work-armv7-6.1/glib-2.62.6/builddir/meson-private/sanitycheckc.exe'.

I suspect this might be post #4307 as last I checked it passed all green on github-action...
My PC is offline for 1-2 more days but I'll have a look into it once back online.
In the meantime, does this PR build directly on top of 5af14c5 ?

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 31, 2020

@hgy59 Found it! ARCHES to ARCHS conversion typo in spksrc.cross-meson-env.mk, thus in turn not providing the cross-build environment to meson :

ifeq ($(findstring $(ARCH),$(ARMv5_ARCHS)),$(ARCH))
  CONFIGURE_ARGS += --cross-file $(MESON_CFG_DIR)/armv5.cfg
endif
ifeq ($(findstring $(ARCH),$(ARMv7_ARCHES)),$(ARCH))
  CONFIGURE_ARGS += --cross-file $(MESON_CFG_DIR)/armv7.cfg
endif
ifeq ($(findstring $(ARCH),$(ARMv7L_ARCHS)),$(ARCH))
  CONFIGURE_ARGS += --cross-file $(MESON_CFG_DIR)/armv7l.cfg
endif

If you don't mind I leave it up to you to push a fix for it. And btw, happy new year!

@hgy59 hgy59 mentioned this pull request Dec 31, 2020
VanStratum and others added 4 commits August 28, 2021 10:42
Add service-setup script.
Change name of downloaded tgz.
Fix dependencies of the spk.
Add rule to compile on ppc platforms.
Remove beta status.
Move to diyspk.
- adjust dependencies (cross/pcre replaced by cross/pcre2)
- include sample lua scripts
- use generic link creation for bin file and share folder
@hgy59
Copy link
Contributor

hgy59 commented Aug 28, 2021

sad to say that SPK_USR_LOCAL_LINKS definitly does not support the creation of linked folders in /usr/local/share (#4578)

@hgy59
Copy link
Contributor

hgy59 commented Aug 28, 2021

@VanStratum Good things come to those who wait.
Just updated this long waiting request, but now it runs even on DSM 7.

@hgy59 hgy59 requested a review from ymartin59 August 28, 2021 10:32
@hgy59 hgy59 added the new-cli-tool new tool for a syncli-package label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-cli-tool new tool for a syncli-package synocli-file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants