-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imapfilter: initial package for imapfilter v2.6.16 #3836
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great job done.
Proposed some small changes.
Since imapfilter is a CLI tool for advanced users I propose to add it to synocli-net
.
And when adding to synocli-net, move the spk/imapfilter to diyspk/imapfilter.
There is no automatic link creation for the executables to /usr/local/bin. You have to provide a service-setup script for this.
Add service-setup script. Change name of downloaded tgz. Fix dependencies of the spk. Add rule to compile on ppc platforms. Remove beta status. Move to diyspk.
Thank you for the feedback. |
If I understand correctly the way the changelog and the revision number works,
Should I commit this changelog and "correct" the revision number, or am I misunderstanding something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hgy59 In case we get Meson to cross-compile for fuse in synocli-net
Thank you for your review and your suggestions. I am currently drowned
in work and unable to work on this right now, but I will apply your
changes as soon as possible.
|
Add service-setup script. Change name of downloaded tgz. Fix dependencies of the spk. Add rule to compile on ppc platforms. Remove beta status. Move to diyspk.
@th0ma7 the meson build (#4307) does not work in the spksrc build environment.
|
I suspect this might be post #4307 as last I checked it passed all green on github-action... |
@hgy59 Found it!
If you don't mind I leave it up to you to push a fix for it. And btw, happy new year! |
Add service-setup script. Change name of downloaded tgz. Fix dependencies of the spk. Add rule to compile on ppc platforms. Remove beta status. Move to diyspk.
- adjust dependencies (cross/pcre replaced by cross/pcre2) - include sample lua scripts - use generic link creation for bin file and share folder
sad to say that |
@VanStratum Good things come to those who wait. |
Motivation: Initial package for imapfilter. Imapfilter allows to apply complex mail filtering rules over IMAP using lua as a scripting language.
Linked issues:
Checklist
all-supported
completed successfullyThe package works properly, but for some reasons unknown to me, the executable files are not linked properly to /usr/local.