Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate package for medusa with python 3 #3756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexey-pimenov
Copy link

Motivation: Medusa started to support python 3 some time ago and works way faster
Linked issues: #3661

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

I'm using this package for already 4 months with no issues

@joel-daros
Copy link

When this PR will be merged to master?


SERVICE_USER = auto
SERVICE_SETUP = src/service-setup.sh
SERVICE_PORT = 8081
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this port is already used by synocommunity package sickbeard.
see wiki page https://github.com/SynoCommunity/spksrc/wiki/SynoCommunity-Used-Ports

please choose a different port, adjust the installation/configuration and document the port on the wiki page.

OR: define SPK_CONFLICT = sickbeard when parallel installations are not possible due concurrent functions (not concurrent ports alone).

@p0psicles
Copy link

@alexey-pimenov could you pls update the port? In the not so distant future medusa is going to drop py2 support, and allot of users are going to panic when not know what to do. There already is a medusa specific PKG circulating. But we would very much prefer a synocomunity supported solution.

@alexey-pimenov
Copy link
Author

alexey-pimenov commented Mar 31, 2020

@p0psicles @hgy59 Sorry for such delayed reply - haven't had spare time recently.
I can look at this PR again this weekend.
But from comments in #3710 it wasn't clear if should I make a separate package or try to make existing package installable on top of python3

So I need help to decide if:

  1. We just change the port or add SPK_CONFLICT, conflict seems more reasonable IMO
  2. Make a package sickbeard-custom-python3 which is an exact copy of the existing package but with different dependency
  3. Try to make sickbeard-custom to work with both python 2 and 3 - which honestly I don't know how to do exactly

In all options, I don't see a way for the users to seamlessly upgrade because backup/restore and cache cleanup would be required.

@p0psicles
Copy link

Preferred option would be 3. But for that you would need an extra prompt. Maybe @BenjV or @mrsparklle can help with that?

For migrating data, users would need to create and recover a backup.

@FireBladeNooT
Copy link

Hi, I propose to update the topic as Pymedusa last release manage only Python 3.
Do you think it's possible to have an update? Whatever the solution is used?

Sincerely

@fredhen
Copy link

fredhen commented Dec 7, 2020

Hi @FireBladeNooT,

Have a look at the Synology wiki section for Medusa. There is a new preferred package from @BenjV that can now be used along with Python 3 support.

In my case (when moving from this package) I performed a backup, uninstalled this package, installed the new package and restored my backup. Just note that it uses port 8897 and cannot be changed.

Hopefully this helps!

@FireBladeNooT
Copy link

Thanks, it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants