add mitmproxy spk #2557
add mitmproxy spk #2557
Conversation
|
|
||
| DEPENDS = cross/libyaml | ||
|
|
||
| HOMEPAGE = |
There was a problem hiding this comment.
We could use some info here ;)
| SPK_REV = 1 | ||
| SPK_ICON = src/mitmproxy.png | ||
|
|
||
| WHEELS = src/requirements.txt |
There was a problem hiding this comment.
To keep the flow in the file, should we perhaps format it as BUILD_DEPENDS, DEPENDS, WHEELS, SPK_DEPENDS, essentially in the order that the entries will be processed?
|
|
||
| SERVICETOOL="/usr/syno/bin/servicetool" | ||
|
|
||
| syno_group_create () |
There was a problem hiding this comment.
This function can be removed
| addgroup ${USER} ${SYNO_GROUP} | ||
| } | ||
|
|
||
| syno_group_remove () |
| PYTHON_DIR="/usr/local/python" | ||
| PATH="${INSTALL_DIR}/bin:${INSTALL_DIR}/env/bin:${PYTHON_DIR}/bin:${PATH}" | ||
| USER="mitmproxy" | ||
| GROUP="users" |
There was a problem hiding this comment.
I belive the users group isn't correct here. Does the package need file system access? For DSM5, we generally use the nobody group instead.
FTR, DSM6 users will not be member of the users group at all (we'll just use our sc-* groups if access to the FS is needed), and one thing to check if if there's even a nobody group.
There was a problem hiding this comment.
On DSM6, I can confirm nobody group is available. On my system, domoticz account belongs to that group. I also can mention subliminal is in users group.
There was a problem hiding this comment.
@ymartin59 Just to check: are you sure the nobody group is available on a clean DSM6 environment, and not that it was created by one of our packages you have installed?
As for the subliminal user, yes, that's expected if you installed the user while on DSM5. It's not a DSM6 package...none of our packages are.
| @@ -0,0 +1,38 @@ | |||
| https://github.com/mitmproxy/mitmproxy/archive/v0.18.2.tar.gz | |||
| backports.ssl_match_hostname>=3.5.0.1, <3.6 | |||
There was a problem hiding this comment.
All the versions in this file should be pinned to exactly 1 version (==) for reproducability reasons, otherwise we will not be able to recreate the exact same package when even 1 of these requirements updates.
Run a pip freeze > requirements.txt when you've got everything installed, and use that as a base instead.
Motivation: make mitmproxy available on Synology Devices.
Linked issues: #2554
Checklist
all-supportedcompleted successfully