Make a directory safely without raising error #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaoul
approved these changes
Apr 30, 2023
|
@Diaoul, much thanks for approving this PR. You mentioned creating a release to get the previous changes implemented in the production server. Let me know if I can be of assistance to get this done. |
|
@Diaoul, any cycles available to revisit pushing this to the live repo? |
|
@Diaoul, I mean sure. I don't mind rolling back any of my previous PRs if we can get the repo unstuck. My understanding from your previous comments was that there was something in there from before which was causing it to crash when we tried to go live with the code. I don't know if this was also the reason the GitHub tests seem to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the upload of SPK files, if this is for a new package or version, folders and corresponding database entries are created. During this process, if there are multiple concurrent requests there is a risk that one process may be attempting to create a folder after another process has already done so. This would result in an exception that can cause the cleanup of folders to occur and put the system into an inconsistent state. This PR changes the way folders are created to not raise an error if one already exists to avoid this.
Fixes: #95