Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make inactive packages downloadable again #106

Closed
hgy59 opened this issue Sep 11, 2023 · 0 comments · Fixed by #102
Closed

Please make inactive packages downloadable again #106

hgy59 opened this issue Sep 11, 2023 · 0 comments · Fixed by #102

Comments

@hgy59
Copy link
Contributor

hgy59 commented Sep 11, 2023 •
edited
Loading

With #98 and #99 the web ui was changed to hide inactive packages.

Luckily this is not yet active in https://synocommunity.com/.

Without the changes, inactive packages can be downloaded and are only inactive (not delivered) for the DSM package center.

This behaviour is mandatory for the following use cases.

The normal use case is installation in the DSM package center. The download links where originally added for installation on SRM that does not have an option to add thirdpary package repositories.

I propose to bring back deactivated packages to the repo.
As an additional guard, I propose to highlight inactive packages (like red or orange label instead of gray) and to add a tooltip for such items saying something like "deactivated, use at your own risk".

Another solution would add a checkbox "Show inactive packages" that is off by default, but this would probably be too much effort.
@hgy59 hgy59 mentioned this issue Nov 11, 2023
Merged
@mreid-tt mreid-tt mentioned this issue Dec 30, 2023
Merged
hgy59 added a commit that referenced this issue Jan 1, 2024
@hgy59
show packages without active versions (leftover of #106)
19ae314 
- do not hide package in packages when there is no active version (SynoCommunity/spksrc#5803)
- remove obsolete TODOs
@hgy59 hgy59 mentioned this issue Jan 1, 2024
Merged
hgy59 added a commit that referenced this issue Jan 1, 2024
@hgy59
show packages without active versions (leftover of #106)
0f4793e 
- do not hide package in packages when there is no active version (SynoCommunity/spksrc#5803)
- remove obsolete TODOs
publicarray pushed a commit that referenced this issue Feb 24, 2024
@hgy59
Improve packages webui (#111)
2db02f3 
Some web ui improvements
+ fix beta label and use different labels for active and inactive packages
+ apply "beta" to package versions instead of packages
+ use green labels for active packages
+ use default (gray) label for inactive packages and add tooltip telling the package is inactive
+ update version date (cut microseconds)
+ fix unclosed span tag in package.html
Show packages without active versions (leftover of #106)
+ do not hide package in packages when there is no active version (Where is the debian-chroot package for DSM5.2? spksrc#5803)
+ remove obsolete TODOs
Fix webpage footer (fixes #116)
+ correct link for SynoCommunity members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref!: various upgrades and fixes SynoCommunity/spkrepo
1 participant
@hgy59