Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Link: CF-545
Description:
All tests were commented out. It's not clear why that was. There's two potential reasons why:
Test method: testCreateUser()
When uncommenting the tests, I ran into a series of undefined errors across all tests and the constructor. It appeared that there were some structural failures with the API wrapper as it was running into numerous object mismatching and undefined exceptions. The
isSet(var)
additions in the code are all examples of object mismatching that occurred for one method.The method was also using unexpected arguments while expecting to pass:
There's a number of things we can do:
Find out if anyone is using the PHP wrapper at all. Slack communications only has a history of use with Microventures years ago, who is still one of our clients, so that may provide useful insight.
Rebuild/refactor the PHP wrapper for stability if the demand is there but the satisfaction is not.