Delete "strand" argument in SeqFeature() due to deprecation and update Complexity Scores expected from IDT #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e expected Complexity Scores from IDT Changes done to get the builds going again.
jakebeal
commented
Feb 23, 2024
There was a problem hiding this comment.
Reviewing as for pull request #229 - these changes are as expected and should do no harm:
- The strand argument was redundant with the location and deprecated
- The IDT score changes are minor, and unfortunately expected of an external service with no guarantees.
|
I am merging as "self-reviewed" since I am really serving as the reviewer for @jguillen15 's PR #229, which I needed to import to a local branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build problems by deleting "strand" argument in SeqFeature() due to deprecation and update expected Complexity Scores from IDT.
Work by @jguillen15 imported from fork https://github.com/jguillen15/SBOL-utilities