-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ibc_tokens_total_supply config #49
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
04b65fd
Remove ibc_tokens_total_supply config
kimberlybp 591e19c
Merge branch 'master' into fix/remove-ibc-tokens-supply-map
sarah-thong 09dd595
Resolve code comments
sarah-thong 8714231
Set node version in github actions workflow
sarah-thong 0aa9ebd
Add node-gyp as per instructions on github workflow actions
sarah-thong 5948fc9
Add ignore-engines flag for node-gyp add command
sarah-thong 6fc332c
Upgrade carbon-js-sdk
sarah-thong 1dc89c7
Set python version to v2.7
sarah-thong eb9da09
Remove gyp install
sarah-thong 2e0f6b0
Set node version to 18 on github job
sarah-thong 6a844b9
Set node version to v18
sarah-thong 461b55e
Rewrite github actions commands
sarah-thong 0d39764
Remove remnants of ibc supply map + formatting
sarah-thong dbf1148
Remove ellipsis symbols
sarah-thong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,18 +10,17 @@ jobs: | |
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set Node-js version | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '18.14.2' | ||
|
|
||
| - name: Install Dependencies | ||
| uses: borales/[email protected] | ||
| with: | ||
| cmd: install --ignore-engines # will run `yarn install` command | ||
| run: yarn install --ignore-engines # will run `yarn install` command | ||
|
|
||
| - name: Validate featured markets schema | ||
| uses: borales/[email protected] | ||
| with: | ||
| cmd: validate # validate using json schema | ||
| run: yarn validate # validate using json schema | ||
|
|
||
| - name: Test market entries for invalid/duplicate markets | ||
| uses: borales/[email protected] | ||
| with: | ||
| cmd: check-configs mainnet testnet devnet # check using check_configs.ts script | ||
| run: yarn check-configs mainnet testnet devnet # check using check_configs.ts script | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,114 +1,89 @@ | ||
| { | ||
| "title": "Demex Webapp Config", | ||
| "description": "demex-webapp-config is a repository to allow frontends to fetch metadata associated with Demex", | ||
| "type": "object", | ||
| "required": [ | ||
| "network", | ||
| "featured_markets", | ||
| "blacklisted_markets", | ||
| "blacklisted_pools", | ||
| "blacklisted_tokens", | ||
| "ibc_tokens_total_supply" | ||
| ], | ||
| "properties": { | ||
| "network": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "mainnet", | ||
| "testnet", | ||
| "devnet" | ||
| ] | ||
| }, | ||
| "featured_markets": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/$defs/featured_market" | ||
| } | ||
| }, | ||
| "blacklisted_markets": { | ||
| "type": "array", | ||
| "description": "List of blacklisted market names", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_market" | ||
| } | ||
| }, | ||
| "blacklisted_pools": { | ||
| "type": "array", | ||
| "description": "List of blacklisted pool ids", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_pool" | ||
| } | ||
| }, | ||
| "blacklisted_tokens": { | ||
| "type": "array", | ||
| "description": "List of blacklisted token denoms", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_token" | ||
| } | ||
| }, | ||
| "ibc_tokens_total_supply": { | ||
| "type": "array", | ||
| "description": "List of ibc denoms with their respective total supply on Coingecko", | ||
| "items": { | ||
| "$ref": "#/$defs/ibc_total_supply" | ||
| } | ||
| }, | ||
| "transfer_options": { | ||
| "type": "object", | ||
| "description": "List of blockchain networks and their priority numbers, used to set their order in deposit and withdrawal forms transfer option dropdown", | ||
| "patternProperties": { | ||
| ".*": { | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "network_fees": { | ||
| "type": "object", | ||
| "description": "List of token denoms and their priority numbers, used to set their order in network fee preferences", | ||
| "patternProperties": { | ||
| ".*": { | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| "title": "Demex Webapp Config", | ||
| "description": "demex-webapp-config is a repository to allow frontends to fetch metadata associated with Demex", | ||
| "type": "object", | ||
| "required": [ | ||
| "network", | ||
| "featured_markets", | ||
| "blacklisted_markets", | ||
| "blacklisted_pools", | ||
| "blacklisted_tokens", | ||
| "transfer_options", | ||
| "network_fees" | ||
| ], | ||
| "properties": { | ||
| "network": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "mainnet", | ||
| "testnet", | ||
| "devnet" | ||
| ] | ||
| }, | ||
| "featured_markets": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/$defs/featured_market" | ||
| } | ||
| }, | ||
| "blacklisted_markets": { | ||
| "type": "array", | ||
| "description": "List of blacklisted market names", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_market" | ||
| } | ||
| }, | ||
| "blacklisted_pools": { | ||
| "type": "array", | ||
| "description": "List of blacklisted pool ids", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_pool" | ||
| } | ||
| }, | ||
| "blacklisted_tokens": { | ||
| "type": "array", | ||
| "description": "List of blacklisted token denoms", | ||
| "items": { | ||
| "$ref": "#/$defs/blacklisted_token" | ||
| } | ||
| }, | ||
| "transfer_options": { | ||
| "type": "object", | ||
| "description": "List of blockchain networks and their priority numbers, used to set their order in deposit and withdrawal forms transfer option dropdown", | ||
| "patternProperties": { | ||
| ".*": { | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "$defs": { | ||
| "featured_market": { | ||
| "type": "string" | ||
| }, | ||
| "blacklisted_market": { | ||
| "type": "string", | ||
| "description": "Blacklisted market name" | ||
| }, | ||
| "blacklisted_pool": { | ||
| "type": "string", | ||
| "description": "Blacklisted pool id (type: string)", | ||
| "pattern": "^\\d+$" | ||
| }, | ||
| "blacklisted_token": { | ||
| "type": "string", | ||
| "description": "Blacklisted token denom" | ||
| }, | ||
| "ibc_total_supply": { | ||
| "type": "object", | ||
| "description": "Total supply amount of each IBC token listed here", | ||
| "required": [ | ||
| "denom", | ||
| "amount" | ||
| ], | ||
| "properties": { | ||
| "denom": { | ||
| "type": "string", | ||
| "description": "Denom of IBC token on Carbon (e.g. ibc/07FA7831E1920D0C87C9388F86B0108677F6ED0C9DE7E4063F05ED675192405C => STARS)" | ||
| }, | ||
| "amount": { | ||
| "type": "string", | ||
| "description": "total supply of each IBC token on Coingecko", | ||
| "pattern": "^\\d+$" | ||
| } | ||
| } | ||
| "network_fees": { | ||
| "type": "object", | ||
| "description": "List of token denoms and their priority numbers, used to set their order in network fee preferences", | ||
| "patternProperties": { | ||
| ".*": { | ||
| "type": "integer" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| }, | ||
| "$defs": { | ||
| "featured_market": { | ||
| "type": "string" | ||
| }, | ||
| "blacklisted_market": { | ||
| "type": "string", | ||
| "description": "Blacklisted market name" | ||
| }, | ||
| "blacklisted_pool": { | ||
| "type": "string", | ||
| "description": "Blacklisted pool id (type: string)", | ||
| "pattern": "^\\d+$" | ||
| }, | ||
| "blacklisted_token": { | ||
| "type": "string", | ||
| "description": "Blacklisted token denom" | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,15 @@ | ||
| { | ||
| "network": "devnet", | ||
| "featured_markets": [], | ||
| "blacklisted_markets": [ | ||
| "swth_btc2" | ||
| ], | ||
| "blacklisted_pools": [], | ||
| "blacklisted_tokens": [], | ||
| "ibc_tokens_total_supply": [], | ||
| "transfer_options": {}, | ||
| "network_fees": { | ||
| "swth": 0, | ||
| "usdc": 1, | ||
| "eth": 2 | ||
| } | ||
| } | ||
| "network": "devnet", | ||
| "featured_markets": [], | ||
| "blacklisted_markets": [ | ||
| "swth_btc2" | ||
| ], | ||
| "blacklisted_pools": [], | ||
| "blacklisted_tokens": [], | ||
| "transfer_options": {}, | ||
| "network_fees": { | ||
| "swth": 0, | ||
| "usdc": 1, | ||
| "eth": 2 | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to delete the
ibc_total_supplystruct.