Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add market banners config #248

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Add market banners config #248

merged 4 commits into from
Nov 1, 2024

Conversation

thanhpn
Copy link
Collaborator

@thanhpn thanhpn commented Oct 22, 2024

No description provided.

@thanhpn thanhpn requested a review from randy75828 October 23, 2024 01:15
@thanhpn thanhpn force-pushed the feat/market-banners branch 2 times, most recently from 5dc9289 to 698a4ff Compare October 23, 2024 04:25
sarah-thong
sarah-thong reviewed Oct 25, 2024
View reviewed changes
config.schema.json Outdated Show resolved Hide resolved
scripts/check_configs.ts Show resolved Hide resolved
scripts/check_configs.ts Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented Oct 25, 2024 •
edited
Loading

UI Comments

  • Do add the market_banners field description here
    image

@thanhpn thanhpn force-pushed the feat/market-banners branch from 3105d7a to 74b2b57 Compare October 25, 2024 03:46
@thanhpn thanhpn requested a review from sarah-thong October 25, 2024 06:25
@sarah-thong
Copy link
Collaborator

UI Comments

  • Pls sync this branch to the latest master.
    image

sarah-thong
sarah-thong reviewed Oct 28, 2024
View reviewed changes
config.schema.json Outdated Show resolved Hide resolved
scripts/check_configs.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
.github/markets/pr_template.md Outdated Show resolved Hide resolved
@thanhpn thanhpn force-pushed the feat/market-banners branch from 0466110 to 2d30b3e Compare October 28, 2024 03:53
@thanhpn thanhpn requested a review from sarah-thong October 28, 2024 03:54
@thanhpn thanhpn force-pushed the feat/market-banners branch from 2d30b3e to 1ba22c4 Compare October 28, 2024 07:43
@sarah-thong sarah-thong merged commit d91cc94 into master Nov 1, 2024
1 check passed
@sarah-thong sarah-thong deleted the feat/market-banners branch November 1, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-thong sarah-thong sarah-thong approved these changes

@randy75828 randy75828 Awaiting requested review from randy75828

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanhpn @sarah-thong