Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config schema and add validation #159

Merged
merged 5 commits into from
May 16, 2024

Conversation

andrewsoon
Copy link
Contributor

No description provided.

config.schema.json Show resolved Hide resolved
config.schema.json Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented May 15, 2024

Other Comments

  • Do add demex_points_config and perp_pool_promo definitions to .github/markets/pr_template.md.

  • Do update the README.md notes with demex_points_config and perp_pool_promo.
    Screenshot 2024-05-15 at 10 02 46 AM

  • Would be good if you could upgrade carbon-js-sdk version on this project. Though if it takes too long, can skip first.
    Screenshot 2024-05-15 at 9 59 55 AM

.github/markets/pr_template.md Outdated Show resolved Hide resolved
.github/markets/pr_template.md Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented May 16, 2024

Other Comments

  • This error is thrown when running scripts/check_configs.ts. Do help to rectify. Thank you!
    Screenshot 2024-05-16 at 10 11 45 AM

@andrewsoon andrewsoon merged commit 2dc7c95 into master May 16, 2024
1 check passed
@andrewsoon andrewsoon deleted the update/demex-points-config-schema branch May 16, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants