Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cometbft to v0.38.10 #7

Open
wants to merge 130 commits into
base: v0.38.5-patched
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
130 commits
Select commit Hold shift + click to select a range
04636a8
perf(internal/blocksync): avoid double-calling `types.BlockFromProto`…
mergify[bot] Jan 26, 2024
3fa1d5c
build(deps): Bump styfle/cancel-workflow-action from 0.12.0 to 0.12.1…
dependabot[bot] Jan 29, 2024
21c07a4
build(deps): Bump bufbuild/buf-setup-action from 1.28.1 to 1.29.0 (#2…
dependabot[bot] Jan 29, 2024
8c4092b
build(deps): Bump slackapi/slack-github-action from 1.24.0 to 1.25.0 …
dependabot[bot] Jan 29, 2024
6b9defb
fix(privval): retry accepting a connection on errors (backport #2047)…
mergify[bot] Jan 30, 2024
1f48ff9
feat(consensus): additional sanity checks for the size of proposed bl…
mergify[bot] Jan 31, 2024
a0fbb9c
build(deps): Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 (ba…
mergify[bot] Feb 6, 2024
c2d6cb4
refactor(examples): small changes to kvstore app (backport #2267) (#2…
mergify[bot] Feb 8, 2024
aec5e39
build(deps): Bump golangci/golangci-lint-action from 3 to 4 (#2302)
dependabot[bot] Feb 12, 2024
8d52002
chore(docs): alter the section about the effects of `timeout_commit` …
mergify[bot] Feb 12, 2024
ff7cc79
docs: images not rendering properly in docs (backport #2331) (#2338)
mergify[bot] Feb 14, 2024
0a2b829
docs: Fix references about DeliverTx (backport #2330) (#2342)
mergify[bot] Feb 14, 2024
347b1b4
disable revive (#2349)
melekes Feb 15, 2024
8d2d76d
e2e: Add `load_max_txs` option to manifest (backport #2094) (#2334)
mergify[bot] Feb 15, 2024
70db8c0
mempool: export errors (backport #1427) (#2277)
mergify[bot] Feb 15, 2024
cb99e53
feat(e2e): Option to set max block size in bytes at genesis (backport…
mergify[bot] Feb 19, 2024
47583fb
fix(docker-compose): fix subnet (backport #2383) (#2391)
mergify[bot] Feb 20, 2024
27c8055
docs(tutorials/install): add `From Go package` (backport #2414) (#2437)
mergify[bot] Feb 26, 2024
8cd4a69
refactor(consensus): print err from SignAndCheckVote (backport #2346)…
mergify[bot] Feb 26, 2024
851fd2b
fix(jsonrpc): enable HTTP basic auth in WS client (backport #2434) (#…
mergify[bot] Feb 27, 2024
16f92f2
fix: `Rollback`: wrong modification of `state.LastHeightValidatorsCha…
mergify[bot] Feb 27, 2024
91413e6
docs(changelog): add missing entry for #2136 (backport #2459) (#2464)
mergify[bot] Feb 28, 2024
99c1816
ci: check metrics generation in CI checks (backport #2483) (#2485)
mergify[bot] Feb 29, 2024
6ddf85b
build(deps): Bump docker/setup-buildx-action from 3.0.0 to 3.1.0 (#2509)
dependabot[bot] Mar 4, 2024
f356b79
spec(abci): fixes the spec to inform about the presence of invalid ex…
mergify[bot] Mar 5, 2024
2a10503
build(deps): Bump bufbuild/buf-setup-action from 1.29.0 to 1.30.0 (#2…
dependabot[bot] Mar 11, 2024
d27a96e
build(deps): Bump docker/build-push-action from 5.1.0 to 5.2.0 (#2567)
dependabot[bot] Mar 11, 2024
6d606ce
feat(blocksync): set the max number of (concurrently) downloaded bloc…
melekes Mar 11, 2024
6cf6978
feat(blocksync): sort peers by download rate & multiple requests for …
mergify[bot] Mar 12, 2024
9db2930
fix(blocksync): use timer instead of time.After (backport #2584) (#2587)
mergify[bot] Mar 12, 2024
1519562
Release v0.38.6 (#2592)
melekes Mar 13, 2024
51ee8c0
docs: format error in ABCI++ specs under commit and listsnapshots sec…
mergify[bot] Mar 13, 2024
14d32d0
build(deps): Bump docker/login-action from 3.0.0 to 3.1.0 (#2628)
dependabot[bot] Mar 18, 2024
3e8cdb2
build(deps): Bump docker/setup-buildx-action from 3.1.0 to 3.2.0 (#2629)
dependabot[bot] Mar 18, 2024
56b005b
build(deps): Bump docker/build-push-action from 5.2.0 to 5.3.0 (#2630)
dependabot[bot] Mar 18, 2024
9606d28
spec: added missing hyperlink and some clean-up on ABCI spec (#2680)
andynog Mar 27, 2024
fd5b3f3
spec: Add additional information about validator ordering (total powe…
mergify[bot] Apr 5, 2024
68a5627
build(deps): Bump bufbuild/buf-setup-action from 1.30.0 to 1.30.1 (#2…
dependabot[bot] Apr 9, 2024
66494ac
update golang.org/x/net from v0.20.0 to v0.23.0 (#2781)
melekes Apr 11, 2024
575b889
fix(bits): prevent BitArray.UnmarshalJSON from crashing on 0 bits in …
mergify[bot] Apr 11, 2024
e5cf488
refactor(rpc): miss stop PingPongLatencyTimer (backport #2792) (#2795)
mergify[bot] Apr 12, 2024
1f67e39
fix: BootstrapState use custom genesis doc provider (backport: #2791)…
yihuang Apr 12, 2024
de17c2d
build(deps): Bump docker/setup-buildx-action from 3.2.0 to 3.3.0 (#2808)
dependabot[bot] Apr 15, 2024
365d4e4
refactor(rpc): allocate PingPongLatencyTimer on start (backport #2804…
mergify[bot] Apr 15, 2024
d7ab511
chore: fix filenames and format in changelog unclog files (backport #…
mergify[bot] Apr 18, 2024
e8ab44f
build(deps): Bump slackapi/slack-github-action from 1.25.0 to 1.26.0 …
dependabot[bot] Apr 22, 2024
2a8c5ff
perf(libs/json): Lower heap overhead of JSON encoding (backport #2846…
mergify[bot] Apr 23, 2024
a9e045b
perf(txindex): Lower allocation overhead of txIndex matchRange (backp…
mergify[bot] Apr 24, 2024
f6cde44
perf(internal/bits): Significantly speedup bitArray.PickRandom (backp…
mergify[bot] Apr 24, 2024
7cd7ae4
fix(bits): handle last element in PickRandom (backport #2899) (#2901)
mergify[bot] Apr 26, 2024
b67ea6f
fix(mempool): panic when the app returns error on CheckTx request (ba…
mergify[bot] Apr 26, 2024
1b1216c
v0.38.7 (#2908)
melekes Apr 27, 2024
003228b
build(deps): Bump bufbuild/buf-setup-action from 1.30.1 to 1.31.0 (#2…
dependabot[bot] Apr 29, 2024
cdf8c54
build(deps): Bump golangci/golangci-lint-action from 4 to 5 (#2919)
dependabot[bot] Apr 29, 2024
203bf33
perf(state): Cache the block hash (backport #2924) (#2931)
mergify[bot] Apr 29, 2024
a70a989
perf(event bus): Remove expensive Logger debug call in PublishEventTx…
mergify[bot] Apr 29, 2024
cf17465
spec(abci): slight improvements to ABCI spec (@angrav's feedback from…
mergify[bot] Apr 30, 2024
4937f14
perf(internal/blocksync): do not `ValidateBlock` twice (backport #202…
mergify[bot] Apr 30, 2024
457e119
perf(consensus/state): Change finalizeCommit to use applyVerifiedBloc…
mergify[bot] Apr 30, 2024
58627a5
perf(p2p/channel): Speedup NewDelimitedWriter (backport #2949) (#2968)
mergify[bot] May 2, 2024
3f037ed
perf(p2p): Remove unnecessary atomic read (backport #2950) (#2971)
mergify[bot] May 2, 2024
b870a44
perf(p2p/conn): Remove a minint call that was appearing in write pack…
mergify[bot] May 2, 2024
17074c8
refactor(p2p/connection): Slight refactor to sendManyPackets that hel…
mergify[bot] May 2, 2024
3431bc8
perf(internal/bits): Speedup extended commit.BitArray() (backport #29…
mergify[bot] May 2, 2024
ad18292
perf(p2p/connection): Lower wasted re-allocations in sendRoutine (bac…
mergify[bot] May 3, 2024
bef190a
perf(consensus/blockstore): Remove validate basic call from LoadBlock…
mergify[bot] May 3, 2024
bce83b3
feat: add a configurable maximum batch size for RPC requests (backpor…
mergify[bot] May 3, 2024
887a9ff
fix: remove comment about default value (#2867) (backport #3000) (#3013)
mergify[bot] May 6, 2024
a977aa5
perf: Micro optimization to save one allocation per packet (backport …
mergify[bot] May 7, 2024
ed61568
perf: Minor speedup to consenus metrics MarkLateVote (backport #3017)…
mergify[bot] May 7, 2024
9ccdb9b
fix(mempool): Fix data race when rechecking with async ABCI client (b…
mergify[bot] May 7, 2024
705e517
docs: disambiguate protocol version (backport #3034) (#3040)
mergify[bot] May 8, 2024
0c06b31
build(deps): Bump golangci/golangci-lint-action from 5 to 6 (#3068)
dependabot[bot] May 13, 2024
f97bee9
perf(blockstore): Add LRU caches to blockstore operations used in con…
mergify[bot] May 15, 2024
51884f9
build(deps): Bump bufbuild/buf-setup-action from 1.31.0 to 1.32.0 (#3…
dependabot[bot] May 20, 2024
01ca424
fix: TimeoutTicker returns wrong value/timeout pair when timeouts are…
mergify[bot] May 22, 2024
dd124fc
build(deps): Bump bufbuild/buf-setup-action from 1.32.0 to 1.32.1 (#3…
dependabot[bot] May 27, 2024
a38dbb2
fix: docs: default db provider moved from node to config (backport #1…
mergify[bot] May 27, 2024
6adb4fc
build(deps): Bump bufbuild/buf-setup-action from 1.32.1 to 1.32.2 (#3…
dependabot[bot] Jun 3, 2024
ba70f4c
build(deps): Bump docker/login-action from 3.1.0 to 3.2.0 (#3166)
dependabot[bot] Jun 3, 2024
b340e2e
chore: update cosmosnetwork discord url (backport #3153) (#3176)
mergify[bot] Jun 3, 2024
06b6583
build(deps): Bump goreleaser/goreleaser-action from 5 to 6 (#3213)
dependabot[bot] Jun 10, 2024
ee556e3
fix(e2e): reproduction an fixing of missing evidence in `e2e` nightli…
mergify[bot] Jun 11, 2024
94cfccf
build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#3…
dependabot[bot] Jun 17, 2024
cd3851e
build(deps): Bump docker/build-push-action from 5.3.0 to 6.0.0 (#3289)
dependabot[bot] Jun 17, 2024
40409a1
fix(types): DO NOT batch verify if vals keys (backport #3196) (#3308)
mergify[bot] Jun 20, 2024
6fe9711
fix(mempool): wrong request type when rechecking (#3264)
hvanz Jun 21, 2024
0ec3f0b
build(deps): Bump bufbuild/buf-setup-action from 1.33.0 to 1.34.0 (#3…
dependabot[bot] Jun 24, 2024
064662b
build(deps): Bump docker/build-push-action from 6.0.0 to 6.1.0 (#3326)
dependabot[bot] Jun 24, 2024
201aa2c
fix(mempool)!: stop accepting TXs in the mempool if we can't keep up …
mergify[bot] Jun 24, 2024
4ad41c0
chore(types): add test for ValidatorSet#AllKeysHaveSameType (backport…
mergify[bot] Jun 26, 2024
05ac431
Added tests to check extendedCommit with different vote extension set…
greg-szabo May 3, 2024
a11292e
Tests redone with a byzantine reactor sending wrong blocks
greg-szabo May 3, 2024
126cc87
Refactor test
greg-szabo May 9, 2024
259ec76
also check if extendedcommit was sent when VoteExtensions are disable…
greg-szabo May 9, 2024
1492292
added unclog entry
greg-szabo May 9, 2024
eaee53c
ABC-0013 fix and broken test
greg-szabo May 29, 2024
789be09
blocksync pool ban test
greg-szabo Jun 20, 2024
d38ee19
Update blocksync/reactor_test.go
greg-szabo Jun 21, 2024
ec86f73
Simplified blocksync malicious node test, fix nil pointer error
greg-szabo Jun 22, 2024
26bda8b
Test assertions have more detail
greg-szabo Jun 22, 2024
4cb0df8
Update blocksync/pool_test.go
greg-szabo Jun 24, 2024
872210c
Update blocksync/pool_test.go
greg-szabo Jun 24, 2024
8a473ca
Update blocksync/pool_test.go
greg-szabo Jun 24, 2024
4199f27
Remove one thread to make test more compact
greg-szabo Jun 24, 2024
007efd7
Removed defers from test
greg-szabo Jun 24, 2024
065810c
Readded good peer to test
greg-szabo Jun 24, 2024
0a89ec1
Update blocksync/pool_test.go
greg-szabo Jun 24, 2024
8ba2e4f
Merge pull request from GHSA-hg58-rf2h-6rr7
greg-szabo Jun 27, 2024
6959205
Release/v0.38.8 (#3350)
greg-szabo Jun 27, 2024
4027622
fix(rpc): fix nil pointer error in `/tx` and `/tx_search` (backport #…
mergify[bot] Jun 28, 2024
1e22f66
refactor(mempool)!: remove PreUpdate from Mempool interface and move …
hvanz Jun 28, 2024
1fd2b98
build(deps): Bump docker/build-push-action from 6.1.0 to 6.2.0 (#3381)
dependabot[bot] Jul 1, 2024
4e83f9d
Release/v0.38.9 (#3387)
hvanz Jul 1, 2024
3cf037a
docs(rpc): update /abci_info return parameters (backport #3359) (#3392)
mergify[bot] Jul 2, 2024
ecd56ec
fix(p2p/pex): respect MaxNumOutboundPeers limit while dialing peers p…
mergify[bot] Jul 2, 2024
eea0ec1
docs: remove not existing key from block search query (backport #3399…
mergify[bot] Jul 3, 2024
4e85725
perf(p2p): Only update send monitor once per batch packet msg send (b…
mergify[bot] Jul 5, 2024
0aeebd5
fix(blocksync): don't block in blocksync if our voting power is block…
mergify[bot] Jul 5, 2024
9ca0b49
perf(p2p/conn): Remove unneeded global pool buffers in secret connect…
mergify[bot] Jul 5, 2024
a392c28
build(deps): Bump docker/setup-buildx-action from 3.3.0 to 3.4.0 (#3439)
dependabot[bot] Jul 8, 2024
f2b42d7
build(deps): Bump docker/build-push-action from 6.2.0 to 6.3.0 (#3440)
dependabot[bot] Jul 8, 2024
fcac713
changelog: moving entry (#3396) to right location (#3457)
cason Jul 8, 2024
a1b6c68
feat(libs/pubsub): allow dash symbol in event type/attribute (backpor…
mergify[bot] Jul 9, 2024
0792c8b
fix: invalid `txs_results` returned for legacy ABCI responses (backpo…
mergify[bot] Jul 9, 2024
641d528
doc(changelog): move recent HackerOne changelogs to 'bug fixes' (#3479)
sergio-mena Jul 10, 2024
c2405cc
feat: do not start indexer service (back port: #3331) (#3496)
mmsqe Jul 11, 2024
5f59b42
chore: release `v0.38.10` (#3515)
melekes Jul 15, 2024
7d9c384
Merge branch 'update-from-v0.38.10' into v0.38.5-patched
summitbajaj Nov 28, 2024
397d308
update cometbft
summitbajaj Nov 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed defers from test
  • Loading branch information
greg-szabo committed Jun 27, 2024
commit 007efd72981a97a9a8170478bad15f5b22281f8a
5 changes: 3 additions & 2 deletions blocksync/pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func TestBlockPoolMaliciousNode(t *testing.T) {
})

peers.start()
defer peers.stop()
t.Cleanup(func() { peers.stop() })

// Simulate blocks created on each peer regularly and update pool max height.
go func() {
Expand Down Expand Up @@ -352,7 +352,8 @@ func TestBlockPoolMaliciousNode(t *testing.T) {
}()

testTicker := time.NewTicker(200 * time.Millisecond) // speed of test execution
defer testTicker.Stop()
t.Cleanup(func() { testTicker.Stop() })

bannedOnce := false // true when the malicious peer was banned at least once
startTime := time.Now()

Expand Down