Feat/optimise oracle #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yan-soon
commented
Jul 15, 2024
•
yan-soon
commented
- add hook from carbon to check if a particular result (given a timestamp and oracle id) has already been committed
- prune votes that have been committed
- add chain id to signing of oracle votes
- increase p2p frequency from 100ms -> 250ms
- enable subaccount signing of oracle votes
- add signature prefix to differentiate between main/subaccount signing, and signature type (ed25519/sr25519/secp256k1)
added 11 commits
July 9, 2024 12:48
holyxiaoxin
reviewed
Jul 17, 2024
holyxiaoxin
reviewed
Jul 17, 2024
holyxiaoxin
reviewed
Jul 17, 2024
RavenXce
requested changes
Jul 22, 2024
| } | ||
|
|
||
| const ( | ||
| DefaultOracleSubAccountKeyName = "oracle_sub_account_key.json" |
There was a problem hiding this comment.
can we default to what was previously used by the legacy oracle service
There was a problem hiding this comment.
the legacy oracle service didnt have a key file like this because the key was added directly to the keyring, but since we are signing the oracle votes from cometbft, i used the same format as to how they import validator keys to sign block votes/proposals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.