-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msg history #168
base: main
Are you sure you want to change the base?
Fix msg history #168
Conversation
One problem here is that it looks like it would scroll to the last message only upon loading, which is not the current (desired) behaviour. Flipping the List has the advantage of keeping the view constantly anchored on the bottom, while elements are added and removed. This allows for a flawless inverted scroll experience expected of a chat app, which was the primary reason for implementing the history list as such. |
That should be fixed now. Rotating it by 180 twice gets you to start at bottom immediately without scrolling AND it doesn't sacrifice mouse behaviors. However, it did move the scrollbar to the left which I moved back by adding a geometry reader to get the width of the scrollbar to move it back. In addition to that, I've also combined the day and unread dividers in those cases. |
commit e6f8bde Author: vinkwok <[email protected]> Date: Sat Jul 1 13:44:23 2023 +0800 fix(onboarding): move attributed title declaration out of view body commit 952ddb9 Author: vinkwok <[email protected]> Date: Fri Jun 30 12:16:00 2023 +0800 fix: remove list dividers added in Xcode 15 commit 0684932 Author: vinkwok <[email protected]> Date: Fri Jun 30 12:15:24 2023 +0800 feat(permissions): channel visibility based on permissions
Unflips the messages view. This allows for clicking messages to work properly (namely mentions when I get that released)
However, I did fix the scrolling. Clicking on a reply scrolls to that message and when you switch to a channel, it scrolls to the unread bar or to the bottommost message.