Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtzer0/UI/main #20

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Dtzer0/UI/main #20

wants to merge 12 commits into from

Conversation

Dtzer0
Copy link
Collaborator

@Dtzer0 Dtzer0 commented Mar 9, 2023

Problem1 : 텍스트필드를 맨아래에두면 Product.view의 전체 스크롤뷰에 의해 커뮤니티 댓글계수만큼 텍스트필드가 아래로 밀리는현상 발생
Problem2 : 해서 팝업으로 아예 막으려했는데 돌기만하고 프리뷰에는 뜨지않는 현상 발생
참고부탁드립니다. 일단 작업한것부터 올릴게요.

# Conflicts:
#	MarketApp/MarketApp.xcodeproj/project.pbxproj
#	MarketApp/MarketApp/Component/CartView.swift
#	MarketApp/MarketApp/ProductList/MainView.swift
#	MarketApp/MarketApp/View/ProductDetail/InfoViewModel.swift
#	MarketApp/MarketApp/View/ProductDetail/ProductView.swift
…MAIN

# Conflicts:
#	MarketApp/MarketApp/Component/CartView.swift
#	MarketApp/MarketApp/View/ProductDetail/ProductView.swift
통신은 성공했으나, LazyVGrid에 문제가 있습니다.
Copy link
Collaborator

@Roy-wonji Roy-wonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 영님 점점 코드가 늘고 있어요 좋아요 !!!
코멘트 달았으니까 한번 보시고 알려주세요!!

import ExytePopupView

//MARK : 커뮤니티
let dateformat: DateFormatter = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 여기는 공용 파일을 만들어서 분해 하는거 어떨까요 ??

}
}

struct WriteComments : View {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 한파일에 뷰가 두개가 있네요 파일 을 분해해서 각각 사용 하는 거 어떨까요 ??
왜 저헐게 한파일레 두개의 뷰를 만들었나용 ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

둘 다 커뮤니티 뷰에 속하는 뷰라서 하나에 다 넣은거에요! 하나는 댓글목록UI고 하나는 댓글textfield에요.

.nanumSquareNeo(family: .cBd, size: 15, color: .black)
})
}
}//동작안함. ( bp해두고 돌려봤을때는 잘찍힘 )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 button에서 액션을 해줘야 팝업이 나올거 같아요!


ScrollView {
VStack {
DetailInfo()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 코드가 짧아졌네용 ㅎㅎ 역시 점점 느시는 군요

.font(.system(size: 18, weight: .medium, design: .default))
}.frame(width: 50)
}
.padding(.top, 10)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 이런 경우는 padding을 vertical을 주는거 어떨까요 ??

Copy link
Collaborator

@Roy-wonji Roy-wonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 리뷰 확인 하고 코멘트 달아주세요


import SwiftUI

enum demoImage : String, CaseIterable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dtzer0 이거는 따로 파일을 분리 하는거 어떤가요??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants