Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Add SettingView #33

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Design] Add SettingView #33

wants to merge 2 commits into from

Conversation

LiSeul
Copy link
Collaborator

@LiSeul LiSeul commented May 25, 2023

Motivation ๐Ÿฅณ (์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€/๋ณ€๊ฒฝํ•˜๊ฒŒ ๋œ ์ด์œ )

SettingView ์ถ”๊ฐ€

Key Changes ๐Ÿ”ฅ (์ฃผ์š” ๊ตฌํ˜„/๋ณ€๊ฒฝ ์‚ฌํ•ญ)

  1. SettingView ์ถ”๊ฐ€
  2. ContentView SettingView์•„์ด์ฝ˜ ๋ฐ ์ด๋™๊ฒฝ๋กœ ์ˆ˜์ •

ToDo ๐Ÿ“† (๋‚จ์€ ์ž‘์—…)

์—†์Œ

ScreenShot ๐Ÿ“ท (์ฐธ๊ณ  ์‚ฌ์ง„)

image

To Reviewers ๐Ÿ™ (๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ์ „๋‹ฌํ•˜๊ณ  ์‹ถ์€ ๋ง)

๋“œ๋””์–ด ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค :)

Reference ๐Ÿ”—

ContentView SettingView์•„์ด์ฝ˜ ์ˆ˜์ •ํ•˜์˜€๋Š”๋ฐ gearshape.fill ์‚ฌ์šฉ ์•ˆํ–ˆ๋Š”๋ฐ fill ์•„์ด์ฝ˜์ฒ˜๋Ÿผ ๋– ์„œ ๊ณ ๋ฏผ์ž…๋‹ˆ๋‹ค.ใ… 

Close Issues ๐Ÿ”’ (๋‹ซ์„ Issue)

Close #24

Copy link
Collaborator

@taek0622 taek0622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.
๋”ฑํžˆ ๋ฌธ์ œ๊ฐ€ ๋ ๋งŒํ•œ ๋ถ€๋ถ„์€ ์—†๊ณ , ์ž‘์€ ์ œ์•ˆ ์‚ฌํ•ญ ํ•˜๋‚˜์™€ ํƒญ๋ทฐ ๋ถ€๋ถ„์— ์•„์ด์ฝ˜์— ๊ด€ํ•œ ์ฝ”๋ฉ˜ํŠธ ํ•˜๋‚˜ ๋‚จ๊ฒจ ๋‘์—ˆ์Šต๋‹ˆ๋‹ค.
์ฐธ๊ณ ํ•˜์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.

.tabItem {
Image(systemName: "plus")
Image(systemName: "gearshape")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น ๋ถ€๋ถ„ ํƒญ ์•„์ด์ฝ˜์— fill์„ ์‚ฌ์šฉํ•˜๊ณ  ์‹ถ์ง€ ์•Š์œผ์‹œ๋‹ค๋ฉด, environment value ์ค‘์—์„œ symbolVariant์— ๊ด€ํ•ด์„œ ์ฐพ์•„๋ณด์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น๋ถ€๋ถ„ ์ข€๋” ์ฐพ์•„๋ณด๊ณ  ์ง„ํ–‰ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ใ… ใ… 

Copy link
Collaborator Author

@LiSeul LiSeul Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teb์•„์ด์ฝ˜์ด ๋ชจ๋‘ fill ์ด์—ฌ์„œ... ํ ..... ํšŒ์˜๋–„ ๋ง์”€๋“œ๋ฆฌ๊ฒ ์Š˜๋‹ค! ๐Ÿ˜€

Comment on lines 39 to 53
.alert(isPresented: $isVersionAlert) {
Alert(title: Text("๋ฒ„์ „ ์ •๋ณด"), message: Text("ํ˜„์žฌ ๋ฒ„์ „: 1.0"), dismissButton: .default(Text("ํ™•์ธ")))
}

Button(action: {
self.isResetAlert = true
}) {
Text("์ดˆ๊ธฐํ™”")
}
.font(.subheadline)
.foregroundColor(.black)
.alert(isPresented: $isResetAlert) {
Alert(title: Text("์ดˆ๊ธฐํ™”"), message: Text("์ดˆ๊ธฐํ™” ํ•˜์‹œ๊ฒ ์Šต๋‹ˆ๊นŒ?"), primaryButton: .destructive(Text("์ดˆ๊ธฐํ™”"), action: {
// ์ดˆ๊ธฐํ™” ๋กœ์ง ๊ตฌํ˜„
}), secondaryButton: .cancel(Text("์ทจ์†Œ")))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alert๋“ค์ด ๋ฐ˜๋ณต๋œ๋‹ค๋ฉด Alert๋ฅผ ๋„์šฐ๋Š” ๋ณ€์ˆ˜๋ฅผ ํ•˜๋‚˜๋กœ ํ†ต์ผํ•˜๊ณ , Alert๋“ค์„ ํ•˜๋‚˜์˜ ์ปดํฌ๋„ŒํŠธ๋กœ ๋บ€ ํ›„์—, ๋‚ด๋ถ€ ๋‚ด์šฉ๊ณผ ๋™์ž‘๋งŒ ๋‹ค๋ฅด๊ฒŒ ํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•˜๋ฉด ์–ด๋–จ๊นŒ์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต! ๋ณ€๊ฒฝ ์ง„ํ–‰ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

Copy link
Collaborator Author

@LiSeul LiSeul Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d62de0e ๊ณตํ†ต ๋ฒ„ํŠผ์„ ๋‹ด๋‹นํ•˜๋Š” SettingButton ์ถ”๊ฐ€

@LiSeul LiSeul self-assigned this Jun 8, 2023
@LiSeul LiSeul changed the title Add SettingView [Design] Add SettingView Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Setting UI ๊ตฌํ˜„
2 participants