-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design] Add SettingView #33
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ณ ์ํ์
จ์ต๋๋ค.
๋ฑํ ๋ฌธ์ ๊ฐ ๋ ๋งํ ๋ถ๋ถ์ ์๊ณ , ์์ ์ ์ ์ฌํญ ํ๋์ ํญ๋ทฐ ๋ถ๋ถ์ ์์ด์ฝ์ ๊ดํ ์ฝ๋ฉํธ ํ๋ ๋จ๊ฒจ ๋์์ต๋๋ค.
์ฐธ๊ณ ํ์๋ฉด ์ข์ ๊ฒ ๊ฐ์์.
.tabItem { | ||
Image(systemName: "plus") | ||
Image(systemName: "gearshape") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํด๋น ๋ถ๋ถ ํญ ์์ด์ฝ์ fill
์ ์ฌ์ฉํ๊ณ ์ถ์ง ์์ผ์๋ค๋ฉด, environment value
์ค์์ symbolVariant
์ ๊ดํด์ ์ฐพ์๋ณด์๋ฉด ์ข์ ๊ฒ ๊ฐ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํด๋น๋ถ๋ถ ์ข๋ ์ฐพ์๋ณด๊ณ ์งํํ๊ฒ ์ต๋๋ค ใ ใ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teb์์ด์ฝ์ด ๋ชจ๋ fill ์ด์ฌ์... ํ ..... ํ์๋ ๋ง์๋๋ฆฌ๊ฒ ์๋ค! ๐
Nav/View/SettingView.swift
Outdated
.alert(isPresented: $isVersionAlert) { | ||
Alert(title: Text("๋ฒ์ ์ ๋ณด"), message: Text("ํ์ฌ ๋ฒ์ : 1.0"), dismissButton: .default(Text("ํ์ธ"))) | ||
} | ||
|
||
Button(action: { | ||
self.isResetAlert = true | ||
}) { | ||
Text("์ด๊ธฐํ") | ||
} | ||
.font(.subheadline) | ||
.foregroundColor(.black) | ||
.alert(isPresented: $isResetAlert) { | ||
Alert(title: Text("์ด๊ธฐํ"), message: Text("์ด๊ธฐํ ํ์๊ฒ ์ต๋๊น?"), primaryButton: .destructive(Text("์ด๊ธฐํ"), action: { | ||
// ์ด๊ธฐํ ๋ก์ง ๊ตฌํ | ||
}), secondaryButton: .cancel(Text("์ทจ์"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alert๋ค์ด ๋ฐ๋ณต๋๋ค๋ฉด Alert๋ฅผ ๋์ฐ๋ ๋ณ์๋ฅผ ํ๋๋ก ํต์ผํ๊ณ , Alert๋ค์ ํ๋์ ์ปดํฌ๋ํธ๋ก ๋บ ํ์, ๋ด๋ถ ๋ด์ฉ๊ณผ ๋์๋ง ๋ค๋ฅด๊ฒ ํ ์ ์๋๋ก ํ๋ฉด ์ด๋จ๊น์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ต! ๋ณ๊ฒฝ ์งํํ๊ฒ ์ต๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d62de0e ๊ณตํต ๋ฒํผ์ ๋ด๋นํ๋ SettingButton ์ถ๊ฐ
Motivation ๐ฅณ (์ฝ๋๋ฅผ ์ถ๊ฐ/๋ณ๊ฒฝํ๊ฒ ๋ ์ด์ )
SettingView ์ถ๊ฐ
Key Changes ๐ฅ (์ฃผ์ ๊ตฌํ/๋ณ๊ฒฝ ์ฌํญ)
ToDo ๐ (๋จ์ ์์ )
์์
ScreenShot ๐ท (์ฐธ๊ณ ์ฌ์ง)
To Reviewers ๐ (๋ฆฌ๋ทฐ์ด์๊ฒ ์ ๋ฌํ๊ณ ์ถ์ ๋ง)
๋๋์ด ์ถ๊ฐํ์ต๋๋ค :)
Reference ๐
ContentView SettingView์์ด์ฝ ์์ ํ์๋๋ฐ gearshape.fill ์ฌ์ฉ ์ํ๋๋ฐ fill ์์ด์ฝ์ฒ๋ผ ๋ ์ ๊ณ ๋ฏผ์ ๋๋ค.ใ
Close Issues ๐ (๋ซ์ Issue)
Close #24