Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfe-1825 Changed check circle svg for success alert #1018

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PriJoh
Copy link
Collaborator

@PriJoh PriJoh commented Nov 14, 2024

Description

I updated the check circle SVG to one with the correct color for the success alert.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

github-actions bot commented Nov 14, 2024

Size Change: +78 B (+0.01%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 73.2 kB 0 B
dist/designguide/scripts/dg.js 24.9 kB 0 B
dist/designguide/styles/documentation-payex.css 10.1 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 9.22 kB 0 B
dist/designguide/styles/payex.css 51.8 kB +39 B (+0.08%)
dist/designguide/styles/swedbankpay.css 49.1 kB 0 B
dist/scripts/3563.js 72.1 kB 0 B
dist/scripts/dg-dashboard.js 73.2 kB 0 B
dist/scripts/dg.js 24.9 kB 0 B
dist/scripts/payex.js 325 kB 0 B
dist/scripts/swedbankpay.js 325 kB 0 B
dist/styles/documentation-payex.css 10.1 kB 0 B
dist/styles/documentation-swedbankpay.css 9.22 kB 0 B
dist/styles/payex.css 51.8 kB +39 B (+0.08%)
dist/styles/swedbankpay.css 49.1 kB 0 B

compressed-size-action

WMeander
WMeander previously approved these changes Nov 15, 2024
@@ -1,7 +1,11 @@
@import "../alert.less";

.alert {
&.alert-success,
&.alert-success {
i[class^="swepay-icon-"].swepay-icon-check-circle-filled, i[class*=" swepay-icon-"].swepay-icon-check-circle-filled {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to make this selector more clear we can use the :is() selector:

Suggested change
i[class^="swepay-icon-"].swepay-icon-check-circle-filled, i[class*=" swepay-icon-"].swepay-icon-check-circle-filled {
i:is([class^="swepay-icon-"], [class*=" swepay-icon-"]).swepay-icon-check-circle-filled {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed to that know :)

Copy link
Collaborator

@goldenraphti goldenraphti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good 👍
I added a code suggestion, just to make the selector shorter & hence clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants