-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pfe-1825 Changed check circle svg for success alert #1018
base: develop
Are you sure you want to change the base?
Conversation
Size Change: +78 B (+0.01%) Total Size: 1.16 MB ℹ️ View Unchanged
|
src/less/components/payex/alert.less
Outdated
@@ -1,7 +1,11 @@ | |||
@import "../alert.less"; | |||
|
|||
.alert { | |||
&.alert-success, | |||
&.alert-success { | |||
i[class^="swepay-icon-"].swepay-icon-check-circle-filled, i[class*=" swepay-icon-"].swepay-icon-check-circle-filled { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to make this selector more clear we can use the :is()
selector:
i[class^="swepay-icon-"].swepay-icon-check-circle-filled, i[class*=" swepay-icon-"].swepay-icon-check-circle-filled { | |
i:is([class^="swepay-icon-"], [class*=" swepay-icon-"]).swepay-icon-check-circle-filled { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed to that know :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code is good 👍
I added a code suggestion, just to make the selector shorter & hence clearer
Description
I updated the check circle SVG to one with the correct color for the success alert.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions