Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #1225

Closed
wants to merge 3 commits into from
Closed

Main #1225

wants to merge 3 commits into from

Conversation

snehas-05
Copy link
Contributor

@snehas-05 snehas-05 commented Oct 13, 2024

I have updated the color palette and added a separate folder for the same named as update_color_palette for better understanding of the code.
My folder contains the code for css and javascaript.
html- why it does not contain html code? The answer is because no changes were to be made in html part.
css- updated code provides the dark theme and vibrant accents. It styles the body, headers, links, cards, buttons, and other UI elements to create a cohesive look.
javascript- updated code adds interactivity to the buttons and includes functions for showing and hiding loading states. When a button is clicked, an alert is shown, and a loading indicator can be displayed for a simulated delay.

I request you to kindly merge my code as it will enhance your website (Earlier due to color scheme chosen, the website was not enhanced)
I will be grateful.

Copy link

vercel bot commented Oct 13, 2024

@snehas-05 is attempting to deploy a commit to the Suraj Pratap's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
imagine-ai-suraj-pratap10 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:32pm

@SurajPratap10
Copy link
Owner

share some pics of the changes u made as I can't see them @snehas-05

@snehas-05
Copy link
Contributor Author

Once you will add my code to your project and try running it you will see the changes
As without the whole html code and basic structure of your project I can't run the changes I made until and unless you merge my code

@SurajPratap10
Copy link
Owner

SurajPratap10 commented Oct 13, 2024

check the vercel bot deployed preview site above there u can see the changes if made any @snehas-05 and if u find ur changes there then do share the SS here as I am not able to figure out any changes. Code gets already added on a preview basis once we authorize the vercel bot to deploy and finally we merge after checking the deployed site preview.

@snehas-05
Copy link
Contributor Author

okay give me time till tomorrow. I will check and share the ss with you

@SurajPratap10
Copy link
Owner

okay give me time till tomorrow. I will check and share the ss with you

np, many folks here are new to open source and stuff take ur time 👍

@snehas-05
Copy link
Contributor Author

Thankyou for understanding

@snehas-05
Copy link
Contributor Author

hey @SurajPratap10 I am sorry for the inconvenience made. I realised my mistake that instead of creating a new folder to update color palette, I was supposed to make changes necessary in the already created css file. Now I did that and was trying to generate my pull request but it is showing some kind of error. Could you please help me with that?
Screenshot (100)

@snehas-05
Copy link
Contributor Author

Hey @SurajPratap10 please reply

@SurajPratap10
Copy link
Owner

make a new pr and check @snehas-05 . I am closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants