Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Forms Search Boxes #1038

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Server Forms Search Boxes #1038

wants to merge 3 commits into from
+1,551 −1,357

Conversation

JevLOMCN
Copy link
Contributor

Added the following Search Boxes to Forms:

NPCInfoForm
QuestInfoForm
RecipeInfoForm
GameShopForm
MagicInfoForm

image
image
image
image
image

@JevLOMCN
Server Forms Search Boxes
5eb2926 
Added the following Search Boxes to Forms:

NPCInfoForm
QuestInfoForm
RecipeInfoForm
GameShopForm
MagicInfoForm
@Suprcode
Copy link
Owner

Form textboxes have a property called "PlaceholderText" - no need to do all that weird fake placeholder logic.

https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.textbox.placeholdertext?view=windowsdesktop-9.0

@JevLOMCN
Placeholder Text
bc8b0a0 
Replaced with Placeholder textbox property and cleaned up the code I had added.
@JevLOMCN
Copy link
Contributor Author

That should do it @Suprcode

Suprcode
Suprcode requested changes Dec 30, 2024
View reviewed changes
Copy link
Owner

@Suprcode Suprcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and alot of tidying needed please

Server.MirForms/Database/GameShop.cs Show resolved Hide resolved
Server.MirForms/Database/QuestInfoForm.cs Show resolved Hide resolved
Server.MirForms/Database/RecipeInfoForm.cs Show resolved Hide resolved
@JevLOMCN
Copy link
Contributor Author

Hey @Suprcode what's left to be fixed on this PR? <3

Suprcode
Suprcode requested changes Jan 16, 2025
View reviewed changes
Copy link
Owner

@Suprcode Suprcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not ideal the way you've implemented the recipe filter

Server.MirForms/Database/RecipeInfoForm.cs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Suprcode Suprcode Suprcode requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JevLOMCN @Suprcode