Skip to content

Commit

Permalink
Removed custom archer and assassin armour ordering
Browse files Browse the repository at this point in the history
  • Loading branch information
@Suprcode
Suprcode committed Feb 11, 2021
1 parent 50c5a4b commit 70bb871
Showing 1 changed file with 2 additions and 72 deletions.
74 changes: 2 additions & 72 deletions Client/MirObjects/PlayerObject.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -369,39 +369,7 @@ public virtual void SetLibraries()
#region Armours
if (altAnim)
{
switch (Armour)
{
case 9: //heaven
case 10: //mir
case 11: //oma
case 12: //spirit
BodyLibrary = Armour + 1 < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour + 1] : Libraries.ARArmours[0];
break;

case 19:
BodyLibrary = Armour - 5 < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour - 5] : Libraries.ARArmours[0];
break;

case 29:
case 30:
BodyLibrary = Armour - 14 < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour - 14] : Libraries.ARArmours[0];
break;

case 35:
case 36:
case 37:
case 38:
case 39:
case 40:
case 41:
BodyLibrary = Armour - 32 < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour - 32] : Libraries.ARArmours[0];
break;

default:
BodyLibrary = Armour < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour] : Libraries.ARArmours[0];
break;
}

BodyLibrary = Armour < Libraries.ARArmours.Length ? Libraries.ARArmours[Armour] : Libraries.ARArmours[0];
HairLibrary = Hair < Libraries.ARHair.Length ? Libraries.ARHair[Hair] : null;
}
else
Expand Down Expand Up @@ -496,45 +464,7 @@ public virtual void SetLibraries()
#region Armours
if (altAnim)
{
switch (Armour)
{
case 9: //heaven
case 10: //mir
case 11: //oma
BodyLibrary = Armour + 3 < Libraries.AArmours.Length ? Libraries.AArmours[Armour + 3] : Libraries.AArmours[0];
break;

case 12: //spirit
BodyLibrary = Armour + 4 < Libraries.AArmours.Length ? Libraries.AArmours[Armour + 4] : Libraries.AArmours[0];
break;

case 19:
BodyLibrary = Armour - 3 < Libraries.AArmours.Length ? Libraries.AArmours[Armour - 3] : Libraries.AArmours[0];
break;

case 20:
case 21:
case 22:
case 23: //red bone
case 24:
BodyLibrary = Armour - 17 < Libraries.AArmours.Length ? Libraries.AArmours[Armour - 17] : Libraries.AArmours[0];
break;

case 28:
case 29:
case 30:
BodyLibrary = Armour - 20 < Libraries.AArmours.Length ? Libraries.AArmours[Armour - 20] : Libraries.AArmours[0];
break;

case 34:
BodyLibrary = Armour - 23 < Libraries.AArmours.Length ? Libraries.AArmours[Armour - 23] : Libraries.AArmours[0];
break;

default:
BodyLibrary = Armour < Libraries.AArmours.Length ? Libraries.AArmours[Armour] : Libraries.AArmours[0];
break;
}

BodyLibrary = Armour < Libraries.AArmours.Length ? Libraries.AArmours[Armour] : Libraries.AArmours[0];
HairLibrary = Hair < Libraries.AHair.Length ? Libraries.AHair[Hair] : null;
}
else
Expand Down

9 comments on commit 70bb871

@jxsr099
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Standing normal
image
Abnormal walking
image

@Suprcode
Copy link
Owner Author

@Suprcode Suprcode commented on 70bb871 Feb 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default client /ARArmours and /AAmours have changed orders.

You need to use the autopatcher

https://www.lomcn.org/forum/threads/new-armours-and-armour-re-ordering.105653/#post-1161805

@jxsr099
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't see the forum when you seal IP

@Suprcode
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not my decision unfortunately.

It says as follows -

Archers and Assassin no longer have strange ordering on their lib numbers and custom code to match them up with the correct common armour.
Instead if a common armour is at position 42.lib, any matching archer/assasin lib will also be at position 42.lib
I've also added all new armours to the client to get it up to date with official.
If you're using the autopatcher then you'll need to ensure your code has the most recent changes to remove the custom ordering.

@jxsr099
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, thank you

@Suprcode
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this report. However please do not post these types of issues publicly (especially with visibility of the application used). It is likely to cause peoples servers to be directly attacked.

In future you should email direct [email protected]

@jxsr099
Copy link

@jxsr099 jxsr099 commented on 70bb871 Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will it be repaired

@Suprcode
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connection flooding would ideally be prevented via your host - not the responsibility of the application itself. However I will look in to it to see if it can be easily prevented.

@jxsr099
Copy link

@jxsr099 jxsr099 commented on 70bb871 Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Please sign in to comment.