-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CO-748: metrics-data-transformer job migration from knowlg to coKreat #8
CO-748: metrics-data-transformer job migration from knowlg to coKreat #8
Conversation
@@ -23,6 +23,8 @@ source { | |||
baseUrl = "https://dev.sunbirded.org/api" | |||
} | |||
|
|||
program-service-baseUrl = "http://localhost:9000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be environment variable. Dont hardcode the value
include "base-config.conf" | ||
|
||
kafka { | ||
input.topic = "sunbirddev.learning.graph.events" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Topic value is harcoded. dev or staging or prod should take it from env variable for both topic and groupId
sunbirddev
timezone = "IST" | ||
|
||
service { | ||
content.basePath = "https://localhost:9000/action" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both the basepath
are hardcoded value. Take it from env variable
timezone = "IST" | ||
|
||
service { | ||
content.basePath = "https://localhost:9000/action" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basePath
is hardcoded for both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the previous comments
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: