Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for korea deployments #208

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Updates for korea deployments #208

merged 9 commits into from
Sep 4, 2024

Conversation

himsharma01
Copy link
Contributor

No description provided.

@himsharma01 himsharma01 requested a review from a team as a code owner August 26, 2024 11:18
@himsharma01 himsharma01 changed the title Updated cf templates for korea deployments Updates for korea deployments Aug 26, 2024
@himsharma01
Copy link
Contributor Author

6/7 Tests are passing successfully.
Regarding remaining 1 test - it failing on the new version of cfn-lint which released after our development cycle. Additionally we have tested these templates on stag, long and on productions working well as expected. We'll take care of linting issues in next dev cycle.

@himsharma01 himsharma01 merged commit bf53766 into master Sep 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhil-sumologic akhil-sumologic akhil-sumologic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himsharma01 @akhil-sumologic