feat(ConfigProvider): Modify config merge to do replace instead of update for Specific tags for Remotely managed collectors #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominik Rosiek <[email protected]>
…c/sumologic-otel-collector into j_config_merge_override pull
Co-authored-by: Dominik Rosiek <[email protected]>
jagan2221
changed the title
Co-authored-by: Raj Nishtala <[email protected]>
rnishtala-sumo
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying config merge functionality to do replace for collector_fields tag. Merge behaviour for other fields remains the same existing flow.
Why?
Collector tag edit behaviour change requirement
Public doc which describes this merge behaviour. doc link
Note: We are overriding this merge behaviour only for collector_fields tag of Remotely Managed collectors. Config merge flow of Locally managed collectors remain the same existing flow.