Bypass FQDN resolution in darwin tests #1296
Conversation
Signed-off-by: Christian Kruse <[email protected]>
| @@ -986,10 +986,13 @@ func addClientCredentials(req *http.Request, credentials accessCredentials) { | |||
| req.Header.Add("Authorization", authHeaderValue) | |||
| } | |||
|
|
|||
| // TODO(ck): hostname allows the darwin tests to bypass fqdn. | |||
| var hostname = fqdn.FqdnHostname | |||
|
|
|||
| // getHostname returns the host name consistently with the resource detection processor's defaults | |||
| // TODO: try to dynamically extract this from the resource processor in the pipeline | |||
There was a problem hiding this comment.
is it possible to do what this comment says? i.e extract the hostname from the resource processor.
There was a problem hiding this comment.
Good question. I'd be surprised if extensions had a way to get processor state like that. I also doubt that'd be a productive way to go at least as far as tests are concerned. (i.e. setting up an entire pipeline with the resource detection processor configured to not use os instead of dns.)
Side note, I wager that processor has the same issue (when configured with dns)
There was a problem hiding this comment.
I guess that solution would assume that we'd be using the resource processor in the pipeline like below.
service:
extensions:
- sumologic
pipelines:
logs:
receivers:
- tcplog
processors:
- resource
There was a problem hiding this comment.
@rnishtala-sumo you okay with kicking this can down the road? Maybe noting that option in #1295
Adds a hack to work around issue #1295