Declare globprovider module path correctly #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The globprovider module path did not equal the globprovider package path. This made it unusable with go get. After changing the module path, I fixed up the otelcolbuilder Makefile in order to ensure that it will always import at the latest version correctly. Signed-off-by: Eric Chlebek <[email protected]>
echlebek
force-pushed
the
echlebek/fix-globprovider-module
branch
from
2426211 to
8925e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The globprovider module path did not equal the globprovider package path. This made it unusable with go get, which would complain that the module path and package paths were not equal.
After changing the module path, I fixed up the otelcolbuilder Makefile in order to ensure that it will always import at the latest version correctly.