Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpAMP load/save effective configuration using remote_configuration_directory #1274

Merged
merged 17 commits into from
Oct 13, 2023
Merged

OpAMP load/save effective configuration using remote_configuration_directory #1274

merged 17 commits into from
Oct 13, 2023

Conversation

portertech
Copy link
Contributor

@portertech portertech commented Oct 5, 2023 •
edited
Loading

Updated the OpAMP agent implementation to reflect the OpAMP Sequence Diagram.

  • OpAMP agent effective configuration is ONLY derived from the contents of remote_configuration_directory
  • The contents of remote_configuration_directory are completely managed by the agent. Received remote configuration files are persisted here (replacing any existing contents).
  • OpAMP remote configuration is now optional via accepts_remote_configuration (defaults to true). OpAMP can potentially be used for other purposes.

@github-actions github-actions bot added the go label Oct 5, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2023
@portertech portertech marked this pull request as ready for review October 6, 2023 20:55
@portertech portertech requested a review from a team as a code owner October 6, 2023 20:55
@portertech portertech requested a review from echlebek October 13, 2023 18:24
echlebek
echlebek approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kronk

@portertech portertech merged commit c0520a1 into main Oct 13, 2023
27 checks passed
@portertech portertech deleted the feature/opamp-effective-config branch October 13, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek left review comments

@echlebek echlebek echlebek approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portertech @echlebek @sumo-drosiek