-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windowsadinvreceiver): Adding the Windows Active Directory inventory receiver to the collector #1273
Conversation
d86b9ce
to
beb71a9
Compare
ac7b2cb
to
bbe5c4b
Compare
3e4a6fc
to
e6f3980
Compare
51dae29
to
7071235
Compare
166670b
to
c8fa535
Compare
8513199
to
a154fe1
Compare
67e7835
to
1392413
Compare
246194d
to
33429dc
Compare
33429dc
to
57acf39
Compare
04583a4
to
ccf543c
Compare
@astencel-sumo this last commit has the changes for the changelog, receiver name and the poll interval type. It also has the validation change for an empty DN. |
ccf543c
to
01c51ca
Compare
01c51ca
to
71990c2
Compare
71990c2
to
319e53f
Compare
@astencel-sumo I think everything that we've discussed so far has been covered. I've also validated the format of the logs with the installed collector. Its just a json log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank Raj, I'm approving this request, although I would like to see two more very minor changes.
- The README should make it clear that the
base_dn
configuration property is required. - (related) When user does not pass a non-empty value for the
base_dn
property, the error message should be more descriptive:- the error message should mention the configuration property name
base_dn
- ideally the error message would say bo more specifc, saying explicitly "
base_dn
is required" instead of generic "Invalid value ofbase_dn
".
- the error message should mention the configuration property name
d240ffb
to
28cb6f6
Compare
The Windows Active Directory Inventory receiver collects inventory data from Active Directory. This includes information such as computer names, user names, email addresses, and location information
Uses this library to query data from windows ADSI
https://pkg.go.dev/github.com/go-adsi/adsi
Example configuration (consistent with AD attributes in IC)
Example output
The body of the above log records contain data from the Windows AD server.