fix(k8sprocessor): owner meta deletion grace period #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a deferred deletion queue to the owner metadata cache, allowing time for telemetry data to be processed with correct metadata after the owning resource(s) have been deleted. Signed-off-by: Christian Kruse <[email protected]>
Signed-off-by: Christian Kruse <[email protected]>
Signed-off-by: Christian Kruse <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Christian Kruse <[email protected]>
echlebek
reviewed
Sep 21, 2023
Comment on lines
502
to
511
| op.deleteMu.Lock() | ||
| for i, d := range op.deleteQueue { | ||
| if d.ts.Add(gracePeriod).After(now) { | ||
| break | ||
| } | ||
| cutoff = i + 1 | ||
| } | ||
| toDelete := op.deleteQueue[:cutoff] | ||
| op.deleteQueue = op.deleteQueue[cutoff:] | ||
| op.deleteMu.Unlock() |
There was a problem hiding this comment.
I feel this is worth its own method, and then the Unlock can be deferred
Signed-off-by: Christian Kruse <[email protected]>
Signed-off-by: Christian Kruse <[email protected]>
|
@swiatekm-sumo you cool with yanking the commented out benchmarks? They had drifted a bit even before this CL. Saw that you had been "using" them in earlier PR/issue discussion. |
sumo-drosiek
changed the title
swiatekm
reviewed
Oct 4, 2023
There was a problem hiding this comment.
The overall approach looks good to me. I'd like:
- Comments for the new functions
- A test that actually measures the deletion delay
- Maybe a manual E2E test in Kubernetes to make sure this is ok? I'm not sure this is necessary, but it's not too difficult to do using the Helm Chart integration tests. Let me know if you want to try it, but if not, I'm ok merging this change as-is.
Signed-off-by: Christian Kruse <[email protected]>
Signed-off-by: Christian Kruse <[email protected]>
|
@swiatekm-sumo Updated godocs and tests with assertions on honoring the grace period. Have dug into the E2E tests and may yet manually validate the change, but had to fight with the test suite a bit to get it up and running. |
swiatekm
approved these changes
Oct 9, 2023
Signed-off-by: Christian Kruse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a deferred deletion queue to the owner metadata cache, allowing time for telemetry data to be processed with correct metadata after the owning resource(s) have been deleted.
Closes #1242