Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): on windows automatically restart service on config changes #39

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix(installer): on windows automatically restart service on config changes #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions msi/wix/components.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:util="http://wixtoolset.org/schemas/v4/wxs/util">
<?include variables.wxi ?>

<Fragment>
Expand Down Expand Up @@ -91,7 +91,10 @@
<!-- Add service for OTC -->
<ServiceInstall Id="Service" Name="!(loc.ServiceName)" DisplayName="!(loc.ServiceDisplayName)"
Description="!(loc.ServiceDescription)" Type="ownProcess" Vital="yes" Start="auto" Account="LocalSystem"
ErrorControl="normal" Arguments="[SERVICEARGUMENTS]" Interactive="no" />
ErrorControl="normal" Arguments="[SERVICEARGUMENTS]" Interactive="no">
<util:ServiceConfig FirstFailureActionType="restart" SecondFailureActionType="restart"
ThirdFailureActionType="restart" RestartServiceDelayInSeconds="0" ResetPeriodInDays="0" />
</ServiceInstall>

<!-- Start/Stop/Remove OTC service -->
<ServiceControl Id="StartServiceControl" Name="!(loc.ServiceName)" Start="install" Stop="both" Remove="uninstall" Wait="no" />
Expand Down
1 change: 1 addition & 0 deletions msi/wix/otelcol-sumo.wixproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
<ItemGroup>
<PackageReference Include="WixToolset.Netfx.wixext" Version="4.0.1" />
<PackageReference Include="WixToolset.UI.wixext" Version="4.0.1" />
<PackageReference Include="WixToolset.Util.wixext" Version="4.0.1" />
</ItemGroup>

<!-- <PropertyGroup Condition="'$(Platform)' == 'arm64'"> -->
Expand Down
Loading