Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): allow overriding metrics collector configuration #3314

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Oct 5, 2023

This is the same functionality as we have for other otel-based components.

Needed to add the manager env changes because Github upgraded their runners to helm 3.13.

Checklist

  • Changelog updated or skip changelog label added
  • Template tests added for new features

@swiatekm swiatekm requested a review from a team as a code owner October 5, 2023 12:44
@github-actions github-actions bot added the documentation documentation label Oct 5, 2023
@swiatekm swiatekm force-pushed the feat/metrics-collector/config branch from c50fe02 to 78981e4 Compare October 5, 2023 15:08
@swiatekm swiatekm force-pushed the feat/metrics-collector/config branch from 78981e4 to 962df36 Compare October 9, 2023 14:00
@swiatekm swiatekm force-pushed the feat/metrics-collector/config branch from 962df36 to 507757e Compare October 10, 2023 10:15
@swiatekm swiatekm merged commit 5dc06a5 into main Oct 10, 2023
33 checks passed
@swiatekm swiatekm deleted the feat/metrics-collector/config branch October 10, 2023 10:38
@sumo-backporter
Copy link
Contributor

The backport to release-v3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v3 release-v3
# Navigate to the new working tree
cd .worktrees/backport-release-v3
# Create a new branch
git switch --create backport-3314-to-release-v3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5dc06a5ef0c8c210aac9eae6417b596ae4c85cb3
# Push it to GitHub
git push --set-upstream origin backport-3314-to-release-v3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v3

Then, create a pull request where the base branch is release-v3 and the compare/head branch is backport-3314-to-release-v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants