Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(metrics): move extra processors after sumologic_schema #3306

Merged
merged 1 commit into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3306.changed.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat!(metrics): move extra processors after sumologic_schema
2 changes: 1 addition & 1 deletion deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ processors:
- resource
- k8s_tagger
- source
- sumologic_schema
{{- if .Values.sumologic.metrics.otelcol.extraProcessors }}
{{- range $processor := .Values.sumologic.metrics.otelcol.extraProcessors }}
{{ printf "- %s" ( $processor | keys | first ) | indent 2 }}
{{- end }}
{{- end }}
- resource/remove_k8s_pod_pod_name
- resource/delete_source_metadata
- sumologic_schema
- transform/set_name
- groupbyattrs/group_by_name
- transform/remove_name
Expand Down
7 changes: 7 additions & 0 deletions docs/v4-migration-doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,15 @@ require additional action.
Some Kubernetes objects, for example statefulsets, have a tight (63 characters) limit for their names. Because of that, we truncate the
prefix that is attached to the names. In particular, the value under key `fullnameOverride` will be truncated to 22 characters.

- Moving extra processors in metrics pipeline after sumologic_schema processor

This has been changed in order to make the behaviour consistent with the logs pipeline. Now, the extra processors should use [translated
versions of some attributes][attribute_translation].

[application_metrics_annotation]: ./collecting-application-metrics.md#application-metrics-are-exposed-one-endpoint-scenario
[kubernetes_metrics_v3]:
https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/release-v3/docs/collecting-kubernetes-metrics.md#collecting-kubernetes-metrics
[otel_metrics_filter]: ./collecting-application-metrics.md#filtering-metrics
[v3_migration_guide]: ./v3-migration-doc.md
[attribute_translation]:
https://github.com/SumoLogic/sumologic-otel-collector/tree/v0.85.0-sumo-0/pkg/processor/sumologicschemaprocessor#attribute-translation
2 changes: 1 addition & 1 deletion tests/helm/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,12 @@ func TestMetadataMetricsOtelConfigExtraProcessors(t *testing.T) {
"resource",
"k8s_tagger",
"source",
"sumologic_schema",
"filter/1",
"transform/rename_metric",
"transform/rename_metadata",
"resource/remove_k8s_pod_pod_name",
"resource/delete_source_metadata",
"sumologic_schema",
"transform/set_name",
"groupbyattrs/group_by_name",
"transform/remove_name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ data:
- resource
- k8s_tagger
- source
- sumologic_schema
- resource/remove_k8s_pod_pod_name
- resource/delete_source_metadata
- sumologic_schema
- transform/set_name
- groupbyattrs/group_by_name
- transform/remove_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@ data:
- resource
- k8s_tagger
- source
- sumologic_schema
- resource/remove_k8s_pod_pod_name
- resource/delete_source_metadata
- sumologic_schema
- transform/set_name
- groupbyattrs/group_by_name
- transform/remove_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ data:
- resource
- k8s_tagger
- source
- sumologic_schema
- resource/remove_k8s_pod_pod_name
- resource/delete_source_metadata
- sumologic_schema
- transform/set_name
- groupbyattrs/group_by_name
- transform/remove_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ data:
- resource
- k8s_tagger
- source
- sumologic_schema
- resource/remove_k8s_pod_pod_name
- resource/delete_source_metadata
- sumologic_schema
- transform/set_name
- groupbyattrs/group_by_name
- transform/remove_name
Expand Down
Loading