Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics)!: drop k8s.node.name attribute #3295

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(metrics)!: drop k8s.node.name attribute #3295

merged 1 commit into from
Sep 21, 2023

Conversation

swiatekm
Copy link

Use the node attribute instead. This was only part of the metrics metadata by mistake.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm
fix(metrics)!: drop k8s.node.name attribute
c700706 
Use the `node` attribute instead. This was only part of the metrics
metadata by mistake.
@swiatekm swiatekm added this to the v4.0 milestone Sep 21, 2023
@swiatekm swiatekm marked this pull request as ready for review September 21, 2023 15:33
@swiatekm swiatekm requested a review from a team as a code owner September 21, 2023 15:33
@swiatekm swiatekm merged commit c04f4a6 into main Sep 21, 2023
37 checks passed
@swiatekm swiatekm deleted the fix/metrics/drop-k8s-node-name branch September 21, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
breaking-change documentation documentation integration-tests
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@swiatekm @sumo-drosiek