Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for v3.2 #3254

Merged
merged 1 commit into from
Sep 8, 2023
Merged

chore: drop support for v3.2 #3254

merged 1 commit into from
Sep 8, 2023

Conversation

aboguszewski-sumo
Copy link
Contributor

No description provided.

@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner September 8, 2023 07:49
@github-actions github-actions bot added the documentation documentation label Sep 8, 2023
@aboguszewski-sumo aboguszewski-sumo enabled auto-merge (rebase) September 8, 2023 07:53
| [v3.2](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.2/docs/README.md) | deprecated / supported until 2023-09-01 |
| [v3.1](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.1/docs/README.md) | deprecated / supported until 2023-08-16 |
| [v3.0](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.0/docs/README.md) | deprecated / supported until 2023-08-09 |
| [v3.2](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.2/docs/README.md) | deprecated / unsupported |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the dates are useful information even after a version goes out of support, answers the question "when did it go out of support? how did I miss it? Oh, it was just a couple days ago; or Oh, it's been months."
I propose we change the format of this list in some way that leaves the dates in. This is what most other products do, like Kubernetes for example.

Suggested change
| [v3.2](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.2/docs/README.md) | deprecated / unsupported |
| [v3.2](https://github.com/SumoLogic/sumologic-kubernetes-collection/tree/release-v3.2/docs/README.md) | deprecated / unsupported since 2023-09-01 |

Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, but I think we should change the format of this list so that we don't remove the dates when a version goes out of support.

@aboguszewski-sumo aboguszewski-sumo merged commit 9cb3ab4 into main Sep 8, 2023
18 checks passed
@aboguszewski-sumo aboguszewski-sumo deleted the ab-drop-32-support branch September 8, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants