Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instruction to remove unwanted attributes from systemd logs #3027

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

sumo-drosiek
Copy link
Contributor

This is feature our customer would like to use. WDYT about adding it to regular configuration as the following?

sumologic:
  logs:
    systemd:
      removeAttributes:
      - PRIORITY

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner May 8, 2023 07:44
@github-actions github-actions bot added the documentation documentation label May 8, 2023
@sumo-drosiek sumo-drosiek force-pushed the drosiek-cleanup-systemd branch from 713b439 to 23604ea Compare May 8, 2023 07:46
@andrzej-stencel
Copy link
Contributor

I agree this should be possible without resorting to config.merge. I believe the configuration should allow allowlisting and denylisting attributes.

@sumo-drosiek
Copy link
Contributor Author

I agree this should be possible without resorting to config.merge. I believe the configuration should allow allowlisting and denylisting attributes.

Allowlisting can be little bit complicated AFAIK we have to do it the following way:

  1. copy/move allowlisted attributes to some temporary map
  2. remove body
  3. move temporary map to body

@swiatekm
Copy link

swiatekm commented May 8, 2023

Can't we just add extraProcessors to the systemd pipeline, same as we have for containers?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']

@sumo-drosiek sumo-drosiek added this to the v3.0 milestone Sep 6, 2023
docs/best-practices.md Outdated Show resolved Hide resolved
docs/best-practices.md Outdated Show resolved Hide resolved
Co-authored-by: Mikołaj Świątek <[email protected]>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-cleanup-systemd branch from 0896e47 to c57cbfb Compare September 8, 2023 10:05
@sumo-drosiek sumo-drosiek merged commit 2fa51e0 into main Sep 8, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-cleanup-systemd branch September 8, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants