fix: fix opentelemetry-operator.manager.env value (#3294)

* fix: fix opentelemetry-operator.manager.env value Signed-off-by: Dominik Rosiek <[email protected]> * Apply suggestions from code review * chore: comment out default value from operator Signed-off-by: Dominik Rosiek <[email protected]> --------- Signed-off-by: Dominik Rosiek <[email protected]>
SumoLogic · Oct 6, 2023 · a7e8fe9 · a7e8fe9
1 parent 8cc9cb9
commit a7e8fe9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/deploy/helm/sumologic/README.md b/deploy/helm/sumologic/README.md
@@ -275,7 +275,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
 | `opentelemetry-operator.instrumentationJobImage.image.repository`                     | Name of the image repository used to apply Instrumentation resource                                                                                                                                                                                                                                        | `sumologic/kubernetes-tools`                                                                                                                                                         |
 | `opentelemetry-operator.instrumentationJobImage.image.tag`                            | Name of the image tag used to apply Instrumentation resource                                                                                                                                                                                                                                               | `2.14.0`                                                                                                                                                                             |
 | `opentelemetry-operator.admissionWebhooks`                                            | Admission webhooks make sure only requests with correctly formatted rules will get into the Operator. They also enable the sidecar injection for OpenTelemetryCollector and Instrumentation CR's.                                                                                                          | See [values.yaml]                                                                                                                                                                    |
-| `opentelemetry-operator.manager.env`                                                  | Additional environment variables for opentelemetry-operator helm chart.                                                                                                                                                                                                                                    | `Nil`                                                                                                                                                                                |
+| `opentelemetry-operator.manager.env`                                                  | Additional environment variables for opentelemetry-operator helm chart.                                                                                                                                                                                                                                    | `{"ENABLE_WEBHOOKS": "true"}`                                                                                                                                                        |
 | `otelcolInstrumentation.enabled`                                                      | Enables Sumo Otel Distro Collector StatefulSet to collect telemetry data. [See docs for more information.](/docs/opentelemetry-collector/traces.md)                                                                                                                                                        | `true`                                                                                                                                                                               |
 | `otelcolInstrumentation.autoscaling.enabled`                                          | Option to turn autoscaling on for Sumo Otel Distro Collector StatefulSet and specify params for HPA. Autoscaling needs metrics-server to access cpu metrics.                                                                                                                                               | `false`                                                                                                                                                                              |
 | `otelcolInstrumentation.autoscaling.minReplicas`                                      | Default min replicas for autoscaling.                                                                                                                                                                                                                                                                      | `3`                                                                                                                                                                                  |

diff --git a/deploy/helm/sumologic/values.yaml b/deploy/helm/sumologic/values.yaml
@@ -2435,6 +2435,8 @@ opentelemetry-operator:
       repository: "public.ecr.aws/sumologic/sumologic-otel-collector"
       tag: "0.85.0-sumo-0"
     env:
+      {}
+      # ENABLE_WEBHOOKS: "true"
     resources:
       limits:
         cpu: 250m