Embedded subtitle soft #8915
Open
Embedded subtitle soft #8915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the process of adding subtitles to the ListView by refactoring the code and introducing asynchronous file processing. This includes consolidating redundant methods into a single method that generates the VideoPreviewGeneratorSub object and ensuring null values are handled. Improved user experience by setting the cursor to a wait state during background operations. Signed-off-by: Ivandro Jao <[email protected]>
Display a "please wait" message and change the cursor to a wait cursor when files are being processed in the drag-and-drop operation. Clear the message and reset the cursor once processing is complete. Signed-off-by: Ivandro Jao <[email protected]>
Implemented a visible progress bar to give user feedback during drag-and-drop operations in the GenerateVideoWithSoftSubs form. This enhances the UI by indicating processing status and improving user experience. Signed-off-by: Ivandro Jao <[email protected]>
This commit deletes the unused variable _inputVideoFileName from the GenerateVideoWithSoftSubs class. This cleanup improves code readability and reduces potential confusion during future maintenance. Signed-off-by: Ivandro Jao <[email protected]>
Wrap subtitle list operations within BeginUpdate and EndUpdate calls to reduce UI flicker and improve performance during batch item insertions. Signed-off-by: Ivandro Jao <[email protected]>
Extracted wait state activation and deactivation into separate methods: `ActivateWaitState` and `DeactivateWaitState`. This improves code readability and reduces repetition. Signed-off-by: Ivandro Jao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not block UI / Windows explorer when big file is dropped
Add progress bar which will be visible when dropping large file / several files