large refactor: Thanks to Spoike for clearing up some SendEntity info…

…rmation; SendEntity takes an entity as the first arg, not a float.

+ SENDFLAG_NEWENT (128) was largely an incorrect name for the value, more accurate name is SENDFLAG_FULL_UPDATE.
+ isNew and FULL_UPDATE don't sync up, isNew is the source of truth for an entity new to the client...but might arrive out of order.
+ in light of these changes, I've sorted out the edge-case where user(s) are pre-existing as mechs, but a new user(s) connect having missed the NEWUNIT flag send.
+ FULL_UPDATE will now make sure that all clients receive other clients as-mechs when necessary.
+ I also sorted out critical hit events vs existing crits, and a newly found respawn bug where critical hits carry over.

client/data/data_buildings.qc

@@ -116,7 +116,7 @@ void() sendent_building_settle={
 
 
 /*
-  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_NEWENT
+  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_UPDATE_FULL
   scope = self
   self is building
 */

client/data/data_mapobjs.qc

@@ -83,7 +83,7 @@ void( float isNew, float entFlags ) data_nav_point={
   }
 
   //EVENT - new to player
-  if( (entFlags & SENDFLAG_NEWENT) ){
+  if( (entFlags & SENDFLAG_UPDATE_FULL) ){
     self.data_idx = ReadByte();
   }
 
@@ -166,7 +166,7 @@ void( float isNew, float entFlags ) data_objective={
   }
 
   //EVENT - new to player
-  if( entFlags & SENDFLAG_NEWENT ){
+  if( entFlags & SENDFLAG_UPDATE_FULL ){
     self.data_idx = ReadByte();
     self.data_type = DATA_OBJT;
   }
@@ -227,7 +227,7 @@ void( float isNew, float entFlags ) data_deploy={
   }
 
   //EVENT - new to player
-  if( (entFlags & SENDFLAG_NEWENT) ){
+  if( (entFlags & SENDFLAG_UPDATE_FULL) ){
     self.data_idx = ReadByte();
      nextOrg_x = ReadCoord();
      nextOrg_y = ReadCoord();
@@ -504,7 +504,7 @@ void( float isNew, float entFlags ) data_map_damage={
     self.angles_z = anglemod(ReadAngle());
   }
 
-  if( (entFlags & SENDFLAG_NEWENT) ){
+  if( (entFlags & SENDFLAG_UPDATE_FULL) ){
     self.data_idx = ReadByte();
     self.spawnflags = rint(ceil(ReadLong()));
     self.damageType = ReadByte();
@@ -573,7 +573,7 @@ void( float isNew, float entFlags ) data_particle_cube_meta={
       particleCubeMetaData = self;
     }
   }
-  if( (entFlags & SENDFLAG_NEWENT) ){
+  if( (entFlags & SENDFLAG_UPDATE_FULL) ){
     self.absmin = te_read_vector();
     self.absmax = te_read_vector();
     self.origin = self.absmax - self.absmin;

client/data/data_turrets.qc

@@ -7,7 +7,7 @@ Overview:
 */
 
 /*
-  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_NEWENT
+  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_UPDATE_FULL
   scope = self
   self is building
 */

client/data/headers/data_buildings.qh

@@ -7,7 +7,7 @@ Overview:
 */
 
 /*
-  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_NEWENT
+  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_UPDATE_FULL
   scope = self
   self is building
 */

client/data/headers/data_turrets.qh

@@ -7,7 +7,7 @@ Overview:
 */
 
 /*
-  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_NEWENT
+  client_main.CSQC_ent_update()->Ent Type == building, SENDFLAG_UPDATE_FULL
   scope = self
   self is building
 */

client/network/net_building.qc

@@ -94,7 +94,7 @@ void( float isNew, float changeFlags) sendent_handle_building={
 
   self.clientServerNum = self.entnum;
 
-  if( (changeFlags & SENDFLAG_NEWENT) ){
+  if( (changeFlags & SENDFLAG_UPDATE_FULL) ){
     self.origin_x = ReadCoord();
     self.origin_y = ReadCoord();
     self.origin_z = ReadCoord();
@@ -219,7 +219,7 @@ void( float isNew, float changeFlags) sendent_handle_building={
 
   //EVENT - voice chatter
   if( (changeFlags & SENDFLAG_VOICE) ){
-    if( !(changeFlags & SENDFLAG_NEWENT) ){
+    if( !(changeFlags & SENDFLAG_UPDATE_FULL) ){
       voiceId = ReadByte();
       snd_hud_trnsmsn_addtoqueue(self.ai_voice_group, voiceId, self.ai_voice_limit, self.entnum);
     }