Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for #162 #163

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Solution for #162 #163

merged 4 commits into from
Apr 24, 2022

Conversation

TIANGeng708
Copy link
Contributor

@TIANGeng708 TIANGeng708 commented Apr 23, 2022

I tried to change the sorting logic a little bit. Added the ability to sort using second priority. #162

@SubhamTyagi
Copy link
Owner

Could you explain What this PR will do?

@SubhamTyagi SubhamTyagi added the Discussion Too be discussed label Apr 23, 2022
@TIANGeng708
Copy link
Contributor Author

If we sort apps by size, there will always be different apps with the same size, and sometimes there will be many apps with the same size. In my modification, these apps with the same size will be sorted by the recent use time.

@2catycm
Copy link
Contributor

2catycm commented Apr 24, 2022

good idea

@SubhamTyagi SubhamTyagi merged commit 6e530cc into SubhamTyagi:master Apr 24, 2022
@SubhamTyagi
Copy link
Owner

@TIANGeng708 Could you again reopen this PR. I accidentally rebased this PR instead of squashing it.

@TIANGeng708
Copy link
Contributor Author

@SubhamTyagi Sorry, I do not know what to do. Do you mean that I need to create a new PR?

@TIANGeng708
Copy link
Contributor Author

@2catycm Thank you!

@SubhamTyagi
Copy link
Owner

@SubhamTyagi Sorry, I do not know what to do. Do you mean that I need to create a new PR?

Yes you have to Create a new PR.

@TIANGeng708
Copy link
Contributor Author

@SubhamTyagi OK,I will create a new PR.

SubhamTyagi pushed a commit that referenced this pull request Apr 25, 2022
Sort apps also on second priority

Co-authored-by: TIANGeng708 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Too be discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants