Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for Windows #8

Open
wants to merge 9 commits into
base: external-mem-sample
Choose a base branch
from

Conversation

bashbaug
Copy link

@bashbaug bashbaug commented Nov 7, 2024

Hi @Beanavil, with these changes I was able to successfully run the external memory samples (both the C and C++ versions) on Windows.

@Beanavil
Copy link
Member

Beanavil commented Nov 7, 2024

I added these to my personal branch and ran the actions, but the test still failed. The changes I had made previously were:

  • Fixing some VUID violations, because Máté was able to run (successfully) the examples on his machine (windows+nvidia loader) but he got VUIDs reported from the vulkan validation layer. For the record, I was able to reproduce this too in a Linux machine with a Nvidia loader.
  • Getting the vulkan-1.dll to be present because I checked that it was not in C:\Windows\System32 as it should be if the Vulkan SDK were installed system-wide. I put it inside the vulkan sdk Bin folder and added that to the path.

@bashbaug
Copy link
Author

bashbaug commented Nov 7, 2024

but the test still failed.

Is this sample expected to run via GitHub actions? Is there a Vulkan implementation on the GitHub runners?

Note that the Intel CPU OpenCL implementation used for automated testing does not currently support external memory.

Note also that the other interop samples (conway and nbody) are not part of the automated testing.

@Beanavil
Copy link
Member

Beanavil commented Nov 8, 2024

Is this sample expected to run via GitHub actions? Is there a Vulkan implementation on the GitHub runners?

If you refer to the GPU drivers I think there is not, given that the DLL is missing.

Note that the Intel CPU OpenCL implementation used for automated testing does not currently support external memory.

Hm interesting, I was not aware of that.

Note also that the other interop samples (conway and nbody) are not part of the automated testing.

I think these are not run because they are graphical applications, but I may be wrong.

So to sum up, are we ok with incorporating this commit and the ones I added to my personal branch for fixing the errors reported by the Vulkan validation layers and considering the example ready? And also are we ok with letting this sample be skipped from the github action execution? I think that given that the current fail in the github action seems to be due to an environment issue of the runner and it runs ok in local setups it looks safe to assume this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants