-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for Windows #8
base: external-mem-sample
Are you sure you want to change the base?
Conversation
I added these to my personal branch and ran the actions, but the test still failed. The changes I had made previously were:
|
Is this sample expected to run via GitHub actions? Is there a Vulkan implementation on the GitHub runners? Note that the Intel CPU OpenCL implementation used for automated testing does not currently support external memory. Note also that the other interop samples (conway and nbody) are not part of the automated testing. |
If you refer to the GPU drivers I think there is not, given that the DLL is missing.
Hm interesting, I was not aware of that.
I think these are not run because they are graphical applications, but I may be wrong. So to sum up, are we ok with incorporating this commit and the ones I added to my personal branch for fixing the errors reported by the Vulkan validation layers and considering the example ready? And also are we ok with letting this sample be skipped from the github action execution? I think that given that the current fail in the github action seems to be due to an environment issue of the runner and it runs ok in local setups it looks safe to assume this is ready. |
1c8c8db
to
780296c
Compare
Hi @Beanavil, with these changes I was able to successfully run the external memory samples (both the C and C++ versions) on Windows.