SMD-2259 Fixed crashlytics crash

- Fixed a crash in case time is not convertible to string
StreamAMG · Jul 13, 2023 · b70c78f · b70c78f
1 parent 475706d
commit b70c78f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -3,6 +3,8 @@ Change Log:
 
 All notable changes to this project will be documented in this section.
 
+### 1.2.5 - Fixed crashlytics crash
+
 ### 1.2.4 - Fixed StreamPlay FixtureID field types
 
 ### 1.2.3

diff --git a/Source/StreamSDKPlayKit/Player/Analytics/HeatMap.swift b/Source/StreamSDKPlayKit/Player/Analytics/HeatMap.swift
@@ -56,7 +56,9 @@ class HeatMap {
             if (currentTime < sectionStart || currentTime > sectionEnd) {
                 markNewSection(currentTime: currentTime)
             } else if currentSectionCount > 5 {
-                heatMap[currentSection] = 1
+                if currentSection < heatMap.count {
+                    heatMap[currentSection] = 1
+                }
             } else {
                 currentSectionCount += 1
             }

diff --git a/Source/StreamSDKPlayKit/Player/Controls/AMGPlayKitStandardControl.swift b/Source/StreamSDKPlayKit/Player/Controls/AMGPlayKitStandardControl.swift
@@ -601,6 +601,7 @@ class AMGPlayKitStandardControl: UIView, AMGControlDelegate {
 
         if !time.isFinite || time.isNaN {
             self.errorListener?.onError(error: PlaykitError(entryID: nil, errorParameter: "\(time)", exception: "Failed to convert time to String"))
+            return ""
         }
         var formattedTimeLeft = formatter.string(from: time)!
         let formattedSplit = formattedTimeLeft.split(separator: ":")

diff --git a/StreamAMGSDK.podspec b/StreamAMGSDK.podspec
@@ -2,7 +2,7 @@
 Pod::Spec.new do |spec|
 
   spec.name         = "StreamAMGSDK"
-  spec.version      = "1.2.4"
+  spec.version      = "1.2.5"
   spec.summary      = "Stream AMG SDK"
   spec.swift_versions = "5"