Release/1.3.0 #31
Merged
Release/1.3.0 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed wrong Playback and BitmovinPlayerView name casing across the code, example and documentation - Changed getVideoDetails in order to support multiple Subscriber calls for playlist API returning a Publisher of Result so if an entryId got an error the Publisher continues getting details for others entryIDs - Making PlaybackResponseModel public so we can use video details to fill the playback API media info - Removing mediaTitle from loadPlayer function and BitmovinPlayerView because now the title will be taken from getVideoDetails API automatically even from single entryID - Manage the PlaybackUIView to get a list of PlaybackAPIError for the playlist API as well as a single PlaybackAPIError for loading a single entryID
- Using playlistConfig for multiple videos and sourceConfig for single video - Disable player touch in case no video or playlist loaded - Renamed setup to setupRemoteCommandCenter - Load playlistConfig for playlist or load sourceConfig for single video - Detailed error handling
- Created localised descriptions for PlaybackAPI errors - Fixed small typo - Ordered playlist items as requested - Improved displayed errors
- Implemented playlist next, previous, last, first, seek and activeEntryId - Add entryId as metadata source
- Optimized code for next, previous and seek - Bitmovin player and playlist event listener - Fixed an issue that recreated the player every UI refresh - Removed unused event listener from BitmovinPlayerView - Added event, seek return value for plugin protocol
Fixing loadHLSStream test as @artem-y-pamediagroup mentioned in PR #26
Applying @artem-y-pamediagroup suggestion regarding entryIds naming Co-authored-by: Artem Y. <[email protected]>
…rPlugin.swift Applying @artem-y-pamediagroup suggestion regarding readable coding on next() function Co-authored-by: Artem Y. <[email protected]>
…rPlugin.swift Applying @artem-y-pamediagroup suggestion regarding align plugin version with SDK version Co-authored-by: Artem Y. <[email protected]>
- Added tests for new playlist feature - Fixed testLoadHLSStream checking the right HLS url - Fixed a comment on PlaybackSDKManager
- Renaming next and previous protocol function with playNext and playPrevious as @artem-y-pamediagroup suggested on #26 - Fixing entryIds naming as @artem-y-pamediagroup suggested on #26 - Fixing a warning issue on playNext function
- Added example how to toggle autoplay and background playback - Fixed readme discrepancies - Improved readme example - Renamed PlaybackError to PlaybackAPIError
- Adding new playlist logic fetching video details every playing video - Load playlist passing the starting entryId (entryIDToPlay) - Seek entryId with completion
- Playlist documentation on README file - Added example of loadPlaylist on Tutorial - Example of playlist controls and events on Tutorial - Preview Swift DocC command added to test tutorial locally
- Added entryId to the PlaybackResponseModel - Fixing entryId on sourceConfig metadata field - Fixing issue mixing Live with VOD
- Fixed Tutorial controls and events - Control and Events on Readme with examples
- Apply @artem-y-pamediagroup suggestions on PR #26 - Refresh playlist when switching between live to VOD only
- Apply @artem-y-pamediagroup suggestion on PR #26 to the documentation and Readme
- Making PlaybackResponseModel internal
Applying @artem-y-pamediagroup suggestions on PR #29 - Fix Typo on GetStarted tutorial - Example multiline improving readability
…mentation CORE-5100 CORE-5085 Playlist documentation
- Fixed typo on Readme (loadPlaylist instead of loadPlayer) - Right comment on seek callback
- New public PlaybackVideoDetails class as @artem-y-pamediagroup suggested on PR #26 - Rollback PlaybackResponseModel to internal struct - Renaming PlayBack API folder to Playback API - Added userAgent param comment on PlaybackAPI and PlaybackAPIService - Fixed indentation on parameters comments
- Merging v1.2.1 - Fixing conflicts with v1.2.1 - Added missing analytics parameters comment - Removed unused folder structure file and script
- Updated Swift DocC tutorial
- Rollback generate folder structure script for Github build job
- Convert PlaybackVideoDetails class to struct as @artem-y-pamediagroup suggested on PR #26
- Changed generate_folder_structure script to create Folder Structure md file automatically - Updated Folder Structure file for Tests and Sources directories
…API-integration Feature/core 4594 i os playlist api integration
StefanoStream
requested review from
zachtom,
KharchenkoAlex and
artem-y-pamediagroup
KharchenkoAlex
approved these changes
Dec 6, 2024
KharchenkoAlex
temporarily deployed
to
github-pages
zachtom
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-4594 Releasing Playlist feature on SDK main branch