-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-5162] Implementation for Bitmovin analytics #27
[CORE-5162] Implementation for Bitmovin analytics #27
Conversation
Sources/PlaybackSDK/Player Plugin/BitMovinPlugin/BitMovinPlayerView.swift
Outdated
Show resolved
Hide resolved
@KharchenkoAlex could you please rerun the pipeline and check if the tests are failing? |
Yes. Already checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KharchenkoAlex can we change the parameter name to something like analyticsId
so that it will be clear what that parameter is for.
@artem-y-pamediagroup @KharchenkoAlex what do you think if we change the release branch to |
Yeah you're right @StefanoStream, even though technically the public API changes, it still can be used without changes because we have |
Implemented Bitmovin analytics also added logic for tracking user id