Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-5162] Implementation for Bitmovin analytics #27

Merged

Conversation

KharchenkoAlex
Copy link
Contributor

Implemented Bitmovin analytics also added logic for tracking user id

@artem-y-pamediagroup
Copy link
Contributor

@KharchenkoAlex could you please rerun the pipeline and check if the tests are failing?

@KharchenkoAlex
Copy link
Contributor Author

@KharchenkoAlex could you please rerun the pipeline and check if the tests are failing?

Yes. Already checking

Copy link
Contributor

@StefanoStream StefanoStream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KharchenkoAlex can we change the parameter name to something like analyticsId so that it will be clear what that parameter is for.

@StefanoStream
Copy link
Contributor

@artem-y-pamediagroup @KharchenkoAlex what do you think if we change the release branch to release/1.2.1? It's not a big change, isn't it?

@artem-y-pamediagroup
Copy link
Contributor

@artem-y-pamediagroup @KharchenkoAlex what do you think if we change the release branch to release/1.2.1? It's not a big change, isn't it?

Yeah you're right @StefanoStream, even though technically the public API changes, it still can be used without changes because we have nil as default value for the new parameter. In this case this change won't break any existing code when updated.
I agree we could rename to release/1.2.1 instead of release/1.3.0

@KharchenkoAlex KharchenkoAlex merged commit a2f6b23 into release/1.2.1 Nov 22, 2024
2 checks passed
@KharchenkoAlex KharchenkoAlex mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants